Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove refs to deprecated io/ioutil #1404

Merged
merged 2 commits into from
Sep 7, 2023
Merged

chore: remove refs to deprecated io/ioutil #1404

merged 2 commits into from
Sep 7, 2023

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Sep 5, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
@kruise-bot kruise-bot requested review from FillZpp and veophi September 5, 2023 14:26
@kruise-bot kruise-bot added the size/S size/S 10-29 label Sep 5, 2023
@zmberg
Copy link
Member

zmberg commented Sep 6, 2023

@testwill You should exec 'File is not gofmt-ed with -s (gofmt)' in file checker.go

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1404 (0c5fd8b) into master (a477df8) will increase coverage by 0.06%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1404      +/-   ##
==========================================
+ Coverage   48.25%   48.31%   +0.06%     
==========================================
  Files         152      152              
  Lines       21469    21469              
==========================================
+ Hits        10359    10373      +14     
+ Misses       9973     9963      -10     
+ Partials     1137     1133       -4     
Flag Coverage Δ
unittests 48.31% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zmberg
Copy link
Member

zmberg commented Sep 6, 2023

/lgtm

@zmberg
Copy link
Member

zmberg commented Sep 7, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit d0f7da9 into openkruise:master Sep 7, 2023
21 checks passed
@testwill testwill deleted the ioutil branch September 7, 2023 02:42
lilongfeng0902 pushed a commit to lilongfeng0902/kruise that referenced this pull request Sep 12, 2023
* chore: remove refs to deprecated io/ioutil

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>

* fix: gofmt checker.go

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>

---------

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
@zmberg zmberg added this to the 1.6 milestone Mar 7, 2024
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
* chore: remove refs to deprecated io/ioutil


* fix: gofmt checker.go


---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants