use "leases" by default #1407
use "leases" by default #1407
Conversation
|
Welcome @dsxing! It looks like this is your first PR to openkruise/kruise 🎉 |
|
@dsxing If default use leases, then upgrade kruise from 1.3.0 to 1.5.0 directly, there will have two leader a period of time. |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #1407 +/- ##
==========================================
+ Coverage 48.23% 48.28% +0.04%
==========================================
Files 153 153
Lines 21492 21492
==========================================
+ Hits 10367 10377 +10
+ Misses 9985 9977 -8
+ Partials 1140 1138 -2
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I see it as well, Upgrading from configmaps to leases requires an intermediate step, namely configmapleases. Version 1.3 uses configmaps, while versions 1.4 and 1.5 make use of configmapleases. I am wondering if versions beyond 1.5 can directly use leases. Versions 1.4 and 1.5 serve as transitional stages in this upgrade process. |
|
@dsxing Can you solve the issue, https://github.com/openkruise/kruise/pull/1407/checks?check_run_id=16603745643 |
use leases Signed-off-by: dsxing <xingdashuaostr@126.com>
Alright, it's done. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
LeaderElectionResourceLock use "leases" by default
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how to verify it
NONE
Ⅳ. Special notes for reviews
kubernetes/kubernetes#80289