Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subset capacity planning for UnitedDeployment #1428

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Add subset capacity planning for UnitedDeployment #1428

merged 2 commits into from
Oct 25, 2023

Conversation

veophi
Copy link
Member

@veophi veophi commented Sep 25, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

#1427

@kruise-bot kruise-bot added the size/M size/M: 30-99 label Sep 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023 •
edited by codecov bot
Loading

Codecov Report

Attention: Patch coverage is 83.03030% with 28 lines in your changes missing coverage. Please review.

Project coverage is 48.40%. Comparing base (6488455) to head (e57890c).
Report is 158 commits behind head on master.

Files with missing lines Patch % Lines
...ployment/validating/uniteddeployment_validation.go 77.64% 13 Missing and 6 partials ⚠️
pkg/controller/uniteddeployment/allocator.go 88.60% 6 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1428      +/-   ##
==========================================
+ Coverage   48.28%   48.40%   +0.12%     
==========================================
  Files         153      153              
  Lines       21492    21623     +131     
==========================================
+ Hits        10377    10467      +90     
- Misses       9977    10006      +29     
- Partials     1138     1150      +12
Flag Coverage Δ
unittests 48.40% <83.03%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veophi veophi force-pushed the ud_capacity branch 2 times, most recently from 63263df to 348e8e8 Compare September 25, 2023 08:06
add subset minReplicas&maxReplicas api for UnitedDeployment
024644c 
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
furykerry
furykerry reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kruise-bot kruise-bot added lgtm size/L size/L: 100-499 and removed lgtm size/M size/M: 30-99 labels Sep 25, 2023
@veophi veophi changed the title Add subset capacity api for UnitedDeployment Add subset capacity planning for UnitedDeployment Sep 25, 2023
@veophi veophi force-pushed the ud_capacity branch 3 times, most recently from d016be8 to c8ab96d Compare September 26, 2023 14:34
@kruise-bot kruise-bot added size/XL size/XL: 500-999 and removed size/L size/L: 100-499 labels Oct 20, 2023
furykerry
furykerry reviewed Oct 23, 2023
View reviewed changes
pkg/controller/uniteddeployment/allocator.go Outdated Show resolved Hide resolved
test/e2e/apps/uniteddeployment.go Outdated
tester = framework.NewUnitedDeploymentTester(c, kc, ns)
})

ginkgo.It("capacity planning test", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz add a case for uniteddeployment with specified replicas

pkg/controller/uniteddeployment/allocator.go Show resolved Hide resolved
pkg/controller/uniteddeployment/allocator.go Outdated Show resolved Hide resolved
@veophi veophi force-pushed the ud_capacity branch 3 times, most recently from 79f0887 to 997a0fc Compare October 24, 2023 09:07
add subset capacity planning for UnitiedDeployment
e57890c 
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
@zmberg
Copy link
Member

zmberg commented Oct 24, 2023

/lgtm

furykerry
furykerry reviewed Oct 25, 2023
View reviewed changes
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 18b15d5 into openkruise:master Oct 25, 2023
21 checks passed
@zmberg zmberg added this to the 1.6 milestone Mar 7, 2024
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
@veophi
Add subset capacity planning for UnitedDeployment (openkruise#1428)
a5584fe 
* add subset minReplicas&maxReplicas api for UnitedDeployment


* add subset capacity planning for UnitiedDeployment


---------

Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furykerry furykerry furykerry left review comments

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo

@FillZpp FillZpp Awaiting requested review from FillZpp

Assignees

@furykerry furykerry

@zmberg zmberg

Labels
approved lgtm size/XL size/XL: 500-999
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@veophi @codecov-commenter @zmberg @furykerry @kruise-bot