【fix】fix only initContainers without hash problem #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrisdeng <chrisdeng@futunn.com>
a932846905
changed the title
|
/lgtm |
|
/approve |
ppbits
pushed a commit
to ppbits/kruise
that referenced
this pull request
Apr 4, 2024
Co-authored-by: chrisdeng <chrisdeng@futunn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
fix pod sidecarSet-hash and sidecarSet-hash-without-image is empty when only initContainers sidecarSet apply in the cluster
Ⅱ. Does this pull request fix one issue?
fixes #1101
Ⅲ. Describe how to verify it
①：apply a initContainer sidecarSet in cluster
②：create a pod associating the above sidecarSet
③：Observe if there is a hash on the pod