Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pub readiness check in pub validating #1512

Merged

Conversation

Spground
Copy link
Contributor

Ⅰ. Describe what this PR does

Add PodStateConsistent check condition in PUB validating.

Ⅱ. Does this pull request fix one issue?

How to check whether Pod is available is inconsistent in PUB controllers and webhooks.

if pubcontrol.PubControl.IsPodStateConsistent(pod) && pubcontrol.PubControl.IsPodReady(pod) {

} else if !PubControl.IsPodReady(pod) {

Ⅲ. Describe how to verify it

Make rolling update using inplace-update, delete Pod when inplace-update is not completed, which is supposed to be successful.

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from Fei-Guo and zmberg February 27, 2024 05:17
@kruise-bot
Copy link

Welcome @Spground! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/S size/S 10-29 label Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.72%. Comparing base (5421ee7) to head (a1046c7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1512      +/-   ##
==========================================
+ Coverage   48.55%   48.72%   +0.16%     
==========================================
  Files         157      157              
  Lines       22480    22480              
==========================================
+ Hits        10916    10953      +37     
+ Misses      10360    10323      -37     
  Partials     1204     1204              
Flag Coverage Δ
unittests 48.72% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Spground <pingshan.wj@alibaba-inc.com>
@Spground Spground force-pushed the feature/update-pub-readiness-check branch from e5fabd3 to a1046c7 Compare February 27, 2024 06:17
@kruise-bot kruise-bot added size/M size/M: 30-99 and removed size/S size/S 10-29 labels Feb 27, 2024
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zmberg
Copy link
Member

zmberg commented Feb 28, 2024

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 3b7c731 into openkruise:master Feb 28, 2024
27 checks passed
@zmberg zmberg added this to the 1.6 milestone Mar 7, 2024
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Co-authored-by: Spground <pingshan.wj@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants