-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update pub readiness check in pub validating #1512
update pub readiness check in pub validating #1512
Conversation
Welcome @Spground! It looks like this is your first PR to openkruise/kruise 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1512 +/- ##
==========================================
+ Coverage 48.55% 48.72% +0.16%
==========================================
Files 157 157
Lines 22480 22480
==========================================
+ Hits 10916 10953 +37
+ Misses 10360 10323 -37
Partials 1204 1204
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Spground <pingshan.wj@alibaba-inc.com>
e5fabd3
to
a1046c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Spground <pingshan.wj@alibaba-inc.com>
Ⅰ. Describe what this PR does
Add PodStateConsistent check condition in PUB validating.
Ⅱ. Does this pull request fix one issue?
How to check whether Pod is available is inconsistent in PUB controllers and webhooks.
kruise/pkg/controller/podunavailablebudget/podunavailablebudget_controller.go
Line 380 in 5421ee7
kruise/pkg/control/pubcontrol/pub_control_utils.go
Line 68 in 5421ee7
Ⅲ. Describe how to verify it
Make rolling update using inplace-update, delete Pod when inplace-update is not completed, which is supposed to be successful.
Ⅳ. Special notes for reviews