fix: pod-readiness-controller use Patch to modify Pod instead of Update #1560
Conversation
|
Welcome @BruceAko! It looks like this is your first PR to openkruise/kruise 🎉 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1560 +/- ##
==========================================
+ Coverage 47.91% 47.98% +0.06%
==========================================
Files 162 162
Lines 23491 23501 +10
==========================================
+ Hits 11256 11277 +21
+ Misses 11014 11007 -7
+ Partials 1221 1217 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@furykerry PTAL |
| }) | ||
| return r.Status().Update(context.TODO(), pod) | ||
| // patch pod condition | ||
| status := v1.PodStatus{ |
There was a problem hiding this comment.
It is not necessary to use the RetryOnConflict method when using the patch method.
Signed-off-by: BruceAko <chongzhi@hust.edu.cn>
|
/assign @zmberg |
|
/lgtm |
|
/assign @Fei-Guo |
|
@zmberg @furykerry @Fei-Guo Can this pull request be merged now? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: BruceAko <chongzhi@hust.edu.cn>
Ⅰ. Describe what this PR does
#1557
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews