-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] When CloneSet volumeClaimTemplates changed, Pod must ReCreate update #1561
[feature] When CloneSet volumeClaimTemplates changed, Pod must ReCreate update #1561
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1561 +/- ##
==========================================
+ Coverage 47.91% 49.28% +1.36%
==========================================
Files 162 164 +2
Lines 23491 18811 -4680
==========================================
- Hits 11256 9271 -1985
+ Misses 11014 8318 -2696
- Partials 1221 1222 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7849a57
to
dd43493
Compare
/retest @kruise-bot |
@ABNER-1: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3dc389f
to
aedf80d
Compare
f068dbe
to
8aaaf72
Compare
8aaaf72
to
af8d778
Compare
I will add a feature gate about this feature, and set default value to false. |
df29123
to
d5e6703
Compare
…in cloneset e2e case ignore vct hash changes when inplace-only update strategy type add feature gate and test both case in ut Signed-off-by: Abner-1 <Abner199709@gmail.com>
d5e6703
to
15fab30
Compare
squash commits and retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I would like to ask a question, since the VolumeClaimTemplate is not stored in the ControllerRevision of the controller, how can I roll it back when I modified VolumeClaimTemplate in cloneSet? And how do I create the correct old instance when I publish @ABNER-1 |
Ⅰ. Describe what this PR does
Implemented "When volumeClaimTemplates are modified, the pod must ReCreate update"
Corner case in 4
detail in #1536
Ⅱ. Does this pull request fix one issue?
detail in #1536
fixes #1536
Ⅲ. Describe how to verify it
detail case in #1536
Main test cases:
--- Although the history revision hash is consistent, the vct hash is not, update history revision id and hash value
Ⅳ. Special notes for reviews