Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps k8s to 0.28 #1563

Closed
wants to merge 1 commit into from

Conversation

liangyuanpeng
Copy link
Contributor

Ⅰ. Describe what this PR does

Fixes #1541

Need update controller-gen to 0.14, pending for #1562

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from FillZpp and furykerry April 5, 2024 15:16
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign furykerry for approval by writing /assign @furykerry in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot
Copy link

@liangyuanpeng: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Daseinlux
Copy link

Is there any progress on this PR now?

@liangyuanpeng
Copy link
Contributor Author

@Daseinlux I will take it up on this weekend.

@liangyuanpeng liangyuanpeng marked this pull request as draft April 18, 2024 14:10
@ABNER-1
Copy link
Member

ABNER-1 commented Apr 23, 2024

Is there any new progress on this PR now?

@liangyuanpeng
Copy link
Contributor Author

liangyuanpeng commented Apr 23, 2024

@Daseinlux @ABNER-1

I encountered some resistance and haven't taken the time to resolve it yet. free feel to open a PR work for it if you wan't waiting for this.

@liangyuanpeng
Copy link
Contributor Author

closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Bump K8s dependency to 1.28
5 participants