sidecarset support k8s 1.28 sidecarContainers #1613
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1613 +/- ##
==========================================
+ Coverage 47.91% 49.00% +1.08%
==========================================
Files 162 180 +18
Lines 23491 18803 -4688
==========================================
- Hits 11256 9214 -2042
+ Misses 11014 8376 -2638
+ Partials 1221 1213 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| } | ||
| //process imagePullSecrets | ||
| sidecarSecrets = append(sidecarSecrets, sidecarSet.Spec.ImagePullSecrets...) | ||
| } | ||
|
|
||
| sidecarList := sets.NewString() | ||
| //process containers |
There was a problem hiding this comment.
maybe an TODO, implement PodInjectPolicy for initContainers, currently initcontainers only use AfterAppContainer
zmberg
force-pushed
the
sidecarset-initcontainer
branch
from
1762016 to
6c011d0
Compare
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
zmberg
force-pushed
the
sidecarset-initcontainer
branch
from
6c011d0 to
19cace7
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Currently only support inject sidecarContainers.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews