Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log error when extract container from fieldpath failed #860

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

pigletfly
Copy link
Contributor

Signed-off-by: pigletfly wangbing.adam@gmail.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: pigletfly <wangbing.adam@gmail.com>
@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Dec 20, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #860 (674aefb) into master (308d40b) will increase coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
+ Coverage   48.22%   48.29%   +0.07%     
==========================================
  Files         118      118              
  Lines       11017    11017              
==========================================
+ Hits         5313     5321       +8     
+ Misses       4896     4892       -4     
+ Partials      808      804       -4     
Flag Coverage Δ
unittests 48.29% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/control/sidecarcontrol/util.go 54.74% <0.00%> (ø)
pkg/controller/uniteddeployment/revision.go 67.69% <0.00%> (+1.53%) ⬆️
pkg/controller/cloneset/cloneset_status.go 89.18% <0.00%> (+16.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 308d40b...674aefb. Read the comment docs.

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 21254ca into openkruise:master Dec 20, 2021
FillZpp pushed a commit that referenced this pull request Jan 21, 2022
Signed-off-by: pigletfly <wangbing.adam@gmail.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants