Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs for ResourceDistribution #861

Merged
merged 1 commit into from
Dec 27, 2021
Merged

Conversation

veophi
Copy link
Member

@veophi veophi commented Dec 20, 2021

Signed-off-by: veophi vec.g.sun@gmail.com

Ⅰ. Describe what this PR does

  1. remove forbidden namespaces "kube-system"/ "kube-public";
  2. ignore "already exists" error when dry-run at webhook;
  3. ignore the errors caused by "namespace-terminating";
  4. change the logic when judge whether resource needs to be updated;
  5. watch resource changes;
  6. fix typos and etc.

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Dec 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2021

Codecov Report

Merging #861 (545d53b) into master (0417db8) will increase coverage by 0.05%.
The diff coverage is 72.97%.

❗ Current head 545d53b differs from pull request most recent head 91b1935. Consider uploading reports for the commit 91b1935 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #861      +/-   ##
==========================================
+ Coverage   48.23%   48.29%   +0.05%     
==========================================
  Files         118      118              
  Lines       11036    11054      +18     
==========================================
+ Hits         5323     5338      +15     
- Misses       4901     4904       +3     
  Partials      812      812              
Flag Coverage Δ
unittests 48.29% <72.97%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rcedistribution/resourcedistribution_controller.go 32.41% <42.85%> (+1.69%) ⬆️
...ting/resourcedistribution_create_update_handler.go 59.61% <75.00%> (-1.10%) ⬇️
pkg/controller/resourcedistribution/utils.go 75.35% <86.48%> (-0.06%) ⬇️
...g/webhook/resourcedistribution/validating/utils.go 75.00% <100.00%> (-3.27%) ⬇️
pkg/controller/uniteddeployment/revision.go 67.69% <0.00%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0417db8...91b1935. Read the comment docs.

@veophi veophi force-pushed the rd-fix branch 9 times, most recently from 6e0dc0f to cdf0d63 Compare December 21, 2021 05:34
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

…ata; improve update logic; watch resource changes

Signed-off-by: veophi <vec.g.sun@gmail.com>
Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FillZpp
Copy link
Member

FillZpp commented Dec 27, 2021

/lgtm

@kruise-bot kruise-bot merged commit 06e56fb into openkruise:master Dec 27, 2021
FillZpp pushed a commit that referenced this pull request Jan 21, 2022
…ata; improve update logic; watch resource changes (#861)

Signed-off-by: veophi <vec.g.sun@gmail.com>
@veophi veophi deleted the rd-fix branch January 30, 2022 05:56
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants