fix #879 Statefulset should consider non-available pods when deleting… #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n deleting pods Signed-off-by: 孤月 <guyue.hzy@alibaba-inc.com>
Codecov Report
@@ Coverage Diff @@
## master #880 +/- ##
==========================================
- Coverage 48.23% 47.93% -0.31%
==========================================
Files 118 119 +1
Lines 11016 11237 +221
==========================================
+ Hits 5314 5386 +72
- Misses 4897 5037 +140
- Partials 805 814 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
FillZpp
reviewed
Jan 6, 2022
| @@ -581,9 +581,9 @@ func (ssc *defaultStatefulSetControl) updateStatefulSet( | |||
| continue | |||
| } | |||
| // if we are in monotonic mode and the condemned target is not the first unhealthy Pod block | |||
| if !isRunningAndReady(condemned[target]) && monotonic && condemned[target] != firstUnhealthyPod { | |||
| if avail, _ := isRunningAndAvailable(condemned[target], minReadySeconds); !avail && monotonic && condemned[target] != firstUnhealthyPod { | |||
There was a problem hiding this comment.
Maybe we should also put the available wait time into durationStore to trigger reconcile after this time.
isAvailable, waitTime := isRunningAndAvailable(condemned[target], minReadySeconds)
durationStore.Push(getStatefulSetKey(set), waitTime)…n deleting pods Signed-off-by: 孤月 <guyue.hzy@alibaba-inc.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ppbits
pushed a commit
to ppbits/kruise
that referenced
this pull request
Apr 4, 2024
…n deleting… (openkruise#880) * fix openkruise#879 Statefulset should consider non-available pods when deleting pods * fix openkruise#879 Statefulset should consider non-available pods when deleting pods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
fixes #879 , use
isRunningAndAvailableto instead ofisRunningAndReadyⅡ. Does this pull request fix one issue?
fixes #879
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews