Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support StatefulSetAutoDeletePVC feature #882

Merged
merged 5 commits into from
Mar 22, 2022
Merged

Conversation

veophi
Copy link
Member

@veophi veophi commented Jan 7, 2022

Ⅰ. Describe what this PR does

Cherry pick from kubernetes/kubernetes#99728.

Ⅱ. Does this pull request fix one issue?

fixes #813

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #882 (9476d70) into master (3b0a040) will increase coverage by 0.55%.
The diff coverage is 77.17%.

@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
+ Coverage   49.46%   50.01%   +0.55%     
==========================================
  Files         119      119              
  Lines       11312    11527     +215     
==========================================
+ Hits         5595     5765     +170     
- Misses       4856     4892      +36     
- Partials      861      870       +9     
Flag Coverage Δ
unittests 50.01% <77.17%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...troller/statefulset/stateful_set_status_updater.go 84.61% <ø> (ø)
...kg/controller/statefulset/stateful_update_utils.go 82.75% <ø> (ø)
...g/controller/statefulset/statefulset_controller.go 23.70% <0.00%> (ø)
...oller/statefulset/statefulset_predownload_image.go 0.00% <ø> (ø)
...k/statefulset/validating/statefulset_validation.go 48.98% <16.66%> (-2.95%) ⬇️
pkg/controller/statefulset/stateful_set_control.go 61.71% <68.42%> (+0.30%) ⬆️
pkg/controller/statefulset/stateful_pod_control.go 84.61% <73.07%> (-15.39%) ⬇️
pkg/controller/statefulset/stateful_set_utils.go 82.24% <94.33%> (+5.96%) ⬆️
pkg/controller/daemonset/daemonset_update.go 54.86% <0.00%> (-0.89%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b0a040...9476d70. Read the comment docs.

mattcary and others added 3 commits March 21, 2022 14:00
Signed-off-by: veophi <vec.g.sun@gmail.com>
Signed-off-by: veophi <vec.g.sun@gmail.com>
Signed-off-by: veophi <vec.g.sun@gmail.com>
Signed-off-by: veophi <vec.g.sun@gmail.com>
Signed-off-by: veophi <vec.g.sun@gmail.com>
Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit ce28404 into openkruise:master Mar 22, 2022
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
* Add StatefulSetAutoDeletePVC feature gate


* statefulset PersistentVolumeClaimDeletePolicy api change


* controller change for statefulset auto-delete (implementation)


* controller change for statefulset auto-delete (tests)


* fix the underlying pollution to informer in statefulset controller


Co-authored-by: Matthew Cary <mattcary@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] StatefulSet PVC auto-delete implementation
5 participants