Fix validateSidecarConflict

[pigletfly]

Signed-off-by: pigletfly wangbing.adam@gmail.com

Ⅰ. Describe what this PR does

scenario: a same sidecar container exists in multiple other sidecarset

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

[pigletfly]

/assign @zmberg

[codecov-commenter]

Codecov Report

Merging #884 (870e806) into master (64b66e7) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #884      +/-   ##
==========================================
+ Coverage   47.90%   48.01%   +0.11%     
==========================================
  Files         119      119              
  Lines       11237    11233       -4     
==========================================
+ Hits         5383     5394      +11     
+ Misses       5038     5020      -18     
- Partials      816      819       +3     

Flag	Coverage Δ
unittests	48.01% <100.00%> (+0.11%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...set/validating/sidecarset_create_update_handler.go	52.07% <100.00%> (+1.78%)	⬆️
pkg/controller/daemonset/daemonset_controller.go	36.38% <0.00%> (-0.88%)	⬇️
pkg/controller/cloneset/cloneset_controller.go	52.96% <0.00%> (ø)
pkg/controller/cloneset/sync/cloneset_update.go	44.94% <0.00%> (ø)
pkg/controller/sidecarset/sidecarset_controller.go	13.88% <0.00%> (ø)
pkg/controller/statefulset/stateful_set_control.go	62.58% <0.00%> (+0.08%)	⬆️
pkg/controller/uniteddeployment/revision.go	67.93% <0.00%> (+0.24%)	⬆️
pkg/controller/daemonset/daemonset_util.go	65.77% <0.00%> (+2.01%)	⬆️
pkg/controller/daemonset/update.go	26.76% <0.00%> (+2.52%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64b66e7...870e806. Read the comment docs.

[zmberg]

@pigletfly tks, you are right. But I'd like to think about it in a different way and see if you can:

matchedList := make([]*appsv1alpha1.SidecarSet, 0)
for i := range sidecarSets.Items {
obj := &sidecarSets.Items[i]
if !isSidecarSetNamespaceDiff(sidecarSet, obj) && util.IsSelectorOverlapping(sidecarSet.Spec.Selector, obj.Spec.Selector) {
matchedList = append(matchedList, obj)
}
}

This matchedList can be facilitated later.
Because only two sidecar overlaps are meaningful for comparison, and this situation does not exist "a same sidecar container exists in multiple other sidecarset"?

[pigletfly]

@zmberg PTAL

[zmberg]

/lgtm

[FillZpp]

/approve

[kruise-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [FillZpp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment