-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace reflect with generation #885
Conversation
Welcome @zouyee! It looks like this is your first PR to openkruise/kruise 🎉 |
Codecov Report
@@ Coverage Diff @@
## master #885 +/- ##
==========================================
+ Coverage 47.90% 47.94% +0.04%
==========================================
Files 119 119
Lines 11237 11239 +2
==========================================
+ Hits 5383 5389 +6
+ Misses 5038 5035 -3
+ Partials 816 815 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LG.
/cc @zmberg
f21c408
to
beb22a3
Compare
Signed-off-by: zounengren <zouyee1989@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: zounengren <zouyee1989@gmail.com>
Signed-off-by: zounengren zouyee1989@gmail.com
Ⅰ. Describe what this PR does
replace reflect with generation
Ⅱ. Does this pull request fix one issue?
none
Ⅲ. Describe how to verify it
none
Ⅳ. Special notes for reviews
none