Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace reflect with generation #885

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Conversation

zouyee
Copy link
Contributor

@zouyee zouyee commented Jan 11, 2022

Signed-off-by: zounengren zouyee1989@gmail.com

Ⅰ. Describe what this PR does

replace reflect with generation

Ⅱ. Does this pull request fix one issue?

none

Ⅲ. Describe how to verify it

none

Ⅳ. Special notes for reviews

none

@kruise-bot kruise-bot requested review from FillZpp and zmberg January 11, 2022 06:43
@kruise-bot
Copy link

Welcome @zouyee! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/S size/S 10-29 label Jan 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2022

Codecov Report

Merging #885 (540b297) into master (64b66e7) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #885      +/-   ##
==========================================
+ Coverage   47.90%   47.94%   +0.04%     
==========================================
  Files         119      119              
  Lines       11237    11239       +2     
==========================================
+ Hits         5383     5389       +6     
+ Misses       5038     5035       -3     
+ Partials      816      815       -1     
Flag Coverage Δ
unittests 47.94% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/sidecarset/sidecarset_controller.go 13.88% <0.00%> (ø)
pkg/controller/uniteddeployment/revision.go 66.41% <0.00%> (-1.29%) ⬇️
pkg/controller/cloneset/sync/cloneset_update.go 44.94% <0.00%> (ø)
pkg/controller/statefulset/stateful_set_control.go 62.58% <0.00%> (+0.08%) ⬆️
pkg/controller/cloneset/cloneset_controller.go 55.33% <0.00%> (+2.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64b66e7...540b297. Read the comment docs.

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LG.

/cc @zmberg

pkg/controller/sidecarset/sidecarset_controller.go Outdated Show resolved Hide resolved
@zouyee zouyee force-pushed the replace branch 2 times, most recently from f21c408 to beb22a3 Compare January 13, 2022 03:35
Signed-off-by: zounengren <zouyee1989@gmail.com>
@kruise-bot kruise-bot added size/XS size/XS: 0-9 and removed size/S size/S 10-29 labels Jan 18, 2022
Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FillZpp FillZpp merged commit 2a7eb6d into openkruise:master Jan 19, 2022
FillZpp pushed a commit that referenced this pull request Jan 21, 2022
Signed-off-by: zounengren <zouyee1989@gmail.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants