Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break the loop when we find the current revision #887

Merged

Conversation

shiyan2016
Copy link
Member

Ⅰ. Describe what this PR does

break the loop when we find the current revision

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Jan 12, 2022
Signed-off-by: shiyan2016 <shiyan20160606@gmail.com>
@shiyan2016 shiyan2016 force-pushed the feature/shiyan/optimize-revision branch from 78fddd5 to ee53646 Compare January 12, 2022 07:28
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2022

Codecov Report

Merging #887 (ee53646) into master (580a944) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
+ Coverage   47.83%   47.99%   +0.16%     
==========================================
  Files         119      119              
  Lines       11237    11240       +3     
==========================================
+ Hits         5375     5395      +20     
+ Misses       5044     5023      -21     
- Partials      818      822       +4     
Flag Coverage Δ
unittests 47.99% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/cloneset/cloneset_controller.go 53.14% <100.00%> (+2.55%) ⬆️
pkg/controller/statefulset/stateful_set_control.go 62.58% <100.00%> (+0.08%) ⬆️
pkg/controller/uniteddeployment/revision.go 67.93% <100.00%> (+1.78%) ⬆️
pkg/controller/daemonset/daemonset_controller.go 36.38% <0.00%> (-0.88%) ⬇️
pkg/controller/daemonset/daemonset_util.go 65.77% <0.00%> (+2.01%) ⬆️
pkg/controller/daemonset/update.go 26.76% <0.00%> (+2.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580a944...ee53646. Read the comment docs.

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 2eece61 into openkruise:master Jan 13, 2022
FillZpp pushed a commit that referenced this pull request Jan 21, 2022
Signed-off-by: shiyan2016 <shiyan20160606@gmail.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants