Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloneSet refresh pod states before skipping update when paused #893

Conversation

FillZpp
Copy link
Member

@FillZpp FillZpp commented Jan 18, 2022

Signed-off-by: FillZpp FillZpp.pub@gmail.com

Ⅰ. Describe what this PR does

CloneSet refresh pod states before skipping update when paused

Ⅱ. Does this pull request fix one issue?

fixes #892

Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
@kruise-bot kruise-bot added the size/M size/M: 30-99 label Jan 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #893 (44b4b0b) into master (23d25b4) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
- Coverage   47.96%   47.89%   -0.08%     
==========================================
  Files         119      119              
  Lines       11239    11239              
==========================================
- Hits         5391     5383       -8     
- Misses       5034     5039       +5     
- Partials      814      817       +3     
Flag Coverage Δ
unittests 47.89% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/cloneset/sync/cloneset_update.go 44.94% <0.00%> (ø)
pkg/controller/cloneset/cloneset_controller.go 52.96% <0.00%> (-2.38%) ⬇️
pkg/controller/uniteddeployment/revision.go 66.41% <0.00%> (-1.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d25b4...44b4b0b. Read the comment docs.

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@FillZpp
Copy link
Member Author

FillZpp commented Jan 18, 2022

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 007ef53 into openkruise:master Jan 18, 2022
FillZpp added a commit that referenced this pull request Jan 21, 2022
Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] extra ReadinnesGate with ReCreate updateStrategy
4 participants