Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support in-place update containers with launch priority #909

Conversation

FillZpp
Copy link
Member

@FillZpp FillZpp commented Feb 21, 2022

Signed-off-by: FillZpp FillZpp.pub@gmail.com

Ⅰ. Describe what this PR does

Support in-place update containers with launch priority.

  • For pods without container orders, no guarantees of the execution order during in-place update multiple containers.
  • For pods with container orders:
    • keep execution order during in-place update multiple containers with different priorities.
    • no guarantees of the execution order during in-place update multiple containers with the same priority.

Ⅱ. Does this pull request fix one issue?

fixes #901

@kruise-bot kruise-bot added the size/XL size/XL: 500-999 label Feb 21, 2022
@FillZpp
Copy link
Member Author

FillZpp commented Feb 21, 2022

/cc @furykerry

@kruise-bot kruise-bot requested a review from furykerry February 21, 2022 07:19
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2022

Codecov Report

Merging #909 (f7ee670) into master (d6fb77a) will increase coverage by 0.02%.
The diff coverage is 53.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
+ Coverage   49.14%   49.17%   +0.02%     
==========================================
  Files         119      119              
  Lines       11166    11293     +127     
==========================================
+ Hits         5488     5553      +65     
- Misses       4832     4877      +45     
- Partials      846      863      +17     
Flag Coverage Δ
unittests 49.17% <53.29%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/cloneset/sync/cloneset_update.go 46.48% <0.00%> (ø)
pkg/util/containermeta/env_hash.go 44.82% <0.00%> (-9.34%) ⬇️
...chpriority/container_launch_priority_controller.go 33.70% <35.71%> (-2.17%) ⬇️
pkg/controller/statefulset/stateful_set_control.go 61.40% <50.00%> (ø)
pkg/util/inplaceupdate/inplace_update.go 35.13% <54.90%> (+1.59%) ⬆️
pkg/util/inplaceupdate/inplace_update_defaults.go 49.33% <59.66%> (+9.02%) ⬆️
pkg/controller/uniteddeployment/revision.go 66.41% <0.00%> (-1.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6fb77a...f7ee670. Read the comment docs.

@FillZpp FillZpp force-pushed the support-container-launch-priority-during-inplace-update branch from bd6f6ac to 89172fa Compare February 24, 2022 11:11
@FillZpp FillZpp force-pushed the support-container-launch-priority-during-inplace-update branch from 89172fa to e09eaf0 Compare March 9, 2022 06:29
@FillZpp FillZpp force-pushed the support-container-launch-priority-during-inplace-update branch from e09eaf0 to 655515b Compare March 9, 2022 08:37
@FillZpp FillZpp force-pushed the support-container-launch-priority-during-inplace-update branch from 655515b to 6548a3d Compare March 14, 2022 07:34
@kruise-bot kruise-bot added size/XXL and removed size/XL size/XL: 500-999 labels Mar 14, 2022
@FillZpp FillZpp force-pushed the support-container-launch-priority-during-inplace-update branch from 6548a3d to f7ee670 Compare March 14, 2022 08:44
@FillZpp FillZpp force-pushed the support-container-launch-priority-during-inplace-update branch 3 times, most recently from 3c5ec4e to 83427de Compare March 15, 2022 11:42
Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
@FillZpp FillZpp force-pushed the support-container-launch-priority-during-inplace-update branch from 83427de to 0ca70a5 Compare March 16, 2022 09:16
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@FillZpp
Copy link
Member Author

FillZpp commented Mar 18, 2022

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 180279a into openkruise:master Mar 18, 2022
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Support ordered execution of the application containers during in-place updates in CloneSet
4 participants