Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize dedupCurHistories func in ReconcileDaemonSet #912

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

LastNight1997
Copy link
Contributor

Ⅰ. Describe what this PR does

Optimize dedupCurHistories func in ReconcileDaemonSet. Relabeling pods before dedup needn't in for loop.

@kruise-bot
Copy link

Welcome @LastNight1997! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/M size/M: 30-99 label Feb 25, 2022
@FillZpp
Copy link
Member

FillZpp commented Feb 25, 2022

@LastNight1997 Nice change!

But it seems the user name and email of your commit are not your github config (may be some private git config). And you did not signoff yourself.

Please first git config user.name "YOUR_GITHUB_NAME" and git config user.email "YOUR_GITHUB_EMAIL" in your local kruise repo. Then git commit -s --amend and force push again.

Signed-off-by: LastNight1997 <934104625@qq.com>
@LastNight1997
Copy link
Contributor Author

@FillZpp Thanks, I have signoff myself.

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 601e0db into openkruise:master Feb 25, 2022
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Co-authored-by: xueshengjie <xueshengjie@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants