-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodes updated with labels matching update selector should be added to the queue in daemonset controller #920
Conversation
Codecov Report
@@ Coverage Diff @@
## master #920 +/- ##
==========================================
- Coverage 49.27% 49.27% -0.01%
==========================================
Files 119 119
Lines 11102 11116 +14
==========================================
+ Hits 5471 5477 +6
- Misses 4793 4798 +5
- Partials 838 841 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
4f1ce35
to
8b3532b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Mostly LG, a few nits.
… the queue Signed-off-by: LastNight1997 <934104625@qq.com>
8b3532b
to
9f90e94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for fixing it.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: LastNight1997 934104625@qq.com
Ⅰ. Describe what this PR does
nodes updated with labels matching update selector should be added to the queue in daemonset controller
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews