Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodes updated with labels matching update selector should be added to the queue in daemonset controller #920

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

LastNight1997
Copy link
Contributor

Signed-off-by: LastNight1997 934104625@qq.com

Ⅰ. Describe what this PR does

nodes updated with labels matching update selector should be added to the queue in daemonset controller

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from Fei-Guo and furykerry March 5, 2022 12:07
@kruise-bot kruise-bot added the size/M size/M: 30-99 label Mar 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2022

Codecov Report

Merging #920 (9f90e94) into master (a6414df) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #920      +/-   ##
==========================================
- Coverage   49.27%   49.27%   -0.01%     
==========================================
  Files         119      119              
  Lines       11102    11116      +14     
==========================================
+ Hits         5471     5477       +6     
- Misses       4793     4798       +5     
- Partials      838      841       +3     
Flag Coverage Δ
unittests 49.27% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/daemonset/daemonset_util.go 56.34% <50.00%> (-0.67%) ⬇️
...kg/controller/daemonset/daemonset_event_handler.go 76.52% <100.00%> (+0.41%) ⬆️
pkg/controller/uniteddeployment/revision.go 66.41% <0.00%> (-1.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6414df...9f90e94. Read the comment docs.

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Mostly LG, a few nits.

pkg/controller/daemonset/daemonset_util.go Outdated Show resolved Hide resolved
pkg/controller/daemonset/daemonset_util.go Outdated Show resolved Hide resolved
… the queue

Signed-off-by: LastNight1997 <934104625@qq.com>
Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for fixing it.

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 2b1eaf0 into openkruise:master Mar 8, 2022
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants