Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support in place upgrade Pod injection sidecar container #927

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Mar 15, 2022

Signed-off-by: liheng.zms liheng.zms@alibaba-inc.com

Fixed in PR, #850

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
@kruise-bot kruise-bot requested review from Fei-Guo and FillZpp March 15, 2022 11:25
@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Mar 15, 2022
@zmberg zmberg requested review from veophi and furykerry and removed request for Fei-Guo March 15, 2022 11:25
Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 3f415af into openkruise:master Mar 15, 2022
@zmberg zmberg deleted the fix_sidecarset_update_inject branch March 15, 2022 11:47
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants