-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:add volumes that initcontainers used in sidecarset #929
Conversation
Welcome @outgnaY! It looks like this is your first PR to openkruise/kruise 🎉 |
Codecov Report
@@ Coverage Diff @@
## master #929 +/- ##
==========================================
+ Coverage 49.11% 49.46% +0.34%
==========================================
Files 119 119
Lines 11163 11313 +150
==========================================
+ Hits 5483 5596 +113
- Misses 4833 4856 +23
- Partials 847 861 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
The change looks good to me. Let's add some test cases similar like
|
@outgnaY Thanks. The DCO failed. Please |
/lgtm |
Signed-off-by: wangchongyang.yangtuo <wangchongyang.yangtuo@bytedance.com>
/lgtm @outgnaY Thanks for working on this. Last comment - It seems the user name and email of your commit are not your github config (may be your private git config). Please first |
Signed-off-by: outgnaY <2296176046@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* fix:add volumes used by initContainers * fix:add volumes used by initContainers Co-authored-by: wangchongyang.yangtuo <wangchongyang.yangtuo@bytedance.com>
Ⅰ. Describe what this PR does
fix: sidecarset doesn't insert volumes used in volumeMounts of initContainers
Ⅱ. Does this pull request fix one issue?
fixes #934