Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:add volumes that initcontainers used in sidecarset #929

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

outgnaY
Copy link
Contributor

@outgnaY outgnaY commented Mar 18, 2022

Ⅰ. Describe what this PR does

fix: sidecarset doesn't insert volumes used in volumeMounts of initContainers

Ⅱ. Does this pull request fix one issue?

fixes #934

@kruise-bot kruise-bot requested review from Fei-Guo and FillZpp March 18, 2022 04:48
@kruise-bot
Copy link

Welcome @outgnaY! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Mar 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #929 (af3415e) into master (3f415af) will increase coverage by 0.34%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #929      +/-   ##
==========================================
+ Coverage   49.11%   49.46%   +0.34%     
==========================================
  Files         119      119              
  Lines       11163    11313     +150     
==========================================
+ Hits         5483     5596     +113     
- Misses       4833     4856      +23     
- Partials      847      861      +14     
Flag Coverage Δ
unittests 49.46% <100.00%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/webhook/pod/mutating/sidecarset.go 74.70% <100.00%> (+0.14%) ⬆️
pkg/util/containermeta/env_hash.go 44.82% <0.00%> (-9.34%) ⬇️
...chpriority/container_launch_priority_controller.go 33.70% <0.00%> (-2.17%) ⬇️
pkg/controller/cloneset/cloneset_event_handler.go 79.46% <0.00%> (-0.19%) ⬇️
pkg/controller/cloneset/sync/api.go 0.00% <0.00%> (ø)
pkg/controller/cloneset/utils/cloneset_utils.go 0.00% <0.00%> (ø)
pkg/util/inplaceupdate/inplace_update.go 34.35% <0.00%> (+0.81%) ⬆️
pkg/controller/cloneset/cloneset_controller.go 54.15% <0.00%> (+1.29%) ⬆️
pkg/controller/cloneset/sync/cloneset_update.go 48.24% <0.00%> (+1.75%) ⬆️
pkg/controller/cloneset/cloneset_status.go 89.18% <0.00%> (+5.40%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f415af...af3415e. Read the comment docs.

@Jeffwan
Copy link

Jeffwan commented Mar 18, 2022

The change looks good to me. Let's add some test cases similar like

func TestPodVolumeMountsAppend(t *testing.T) {

@FillZpp
Copy link
Member

FillZpp commented Mar 18, 2022

@outgnaY Thanks. The DCO failed. Please git commit --amend -s to signoff yourself and force push again.

@zmberg
Copy link
Member

zmberg commented Mar 18, 2022

/lgtm

@kruise-bot kruise-bot added lgtm size/L size/L: 100-499 size/XXL and removed lgtm size/XS size/XS: 0-9 size/L size/L: 100-499 labels Mar 18, 2022
@outgnaY outgnaY closed this Mar 21, 2022
@kruise-bot kruise-bot added size/XS size/XS: 0-9 and removed size/XXL labels Mar 21, 2022
Signed-off-by: wangchongyang.yangtuo <wangchongyang.yangtuo@bytedance.com>
@outgnaY outgnaY reopened this Mar 21, 2022
@FillZpp
Copy link
Member

FillZpp commented Mar 21, 2022

/lgtm

@outgnaY Thanks for working on this. Last comment - It seems the user name and email of your commit are not your github config (may be your private git config). Please first git config user.name "YOUR_GITHUB_NAME" and git config user.email "YOUR_GITHUB_EMAIL" in your local kruise repo and then force push again.

wangchongyang.yangtuo and others added 2 commits March 21, 2022 14:52
@kruise-bot kruise-bot removed the lgtm label Mar 21, 2022
Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit b785755 into openkruise:master Mar 21, 2022
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
* fix:add volumes used by initContainers


* fix:add volumes used by initContainers


Co-authored-by: wangchongyang.yangtuo <wangchongyang.yangtuo@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] sidecarset doesn't add volumes used by initContainers
7 participants