-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cri-o imageruntime #930
Conversation
Welcome @diannaowa! It looks like this is your first PR to openkruise/kruise 🎉 |
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Codecov Report
@@ Coverage Diff @@
## master #930 +/- ##
=======================================
Coverage 49.42% 49.42%
=======================================
Files 119 119
Lines 11306 11306
=======================================
Hits 5588 5588
Misses 4857 4857
Partials 861 861
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Mostly LG, well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for working on this.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* support cri-o imageruntime * fix go lint * fix remove handleRuntimeError for CRI client
Ⅰ. Describe what this PR does
Support cri-o image puller with CRI
Ⅱ. Does this pull request fix one issue?
fixes #804
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
Do not support image pulling progress when use cri-o as container runtime.