Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cri-o imageruntime #930

Merged
merged 3 commits into from
Mar 18, 2022
Merged

Conversation

diannaowa
Copy link
Contributor

Ⅰ. Describe what this PR does

Support cri-o image puller with CRI

Ⅱ. Does this pull request fix one issue?

fixes #804

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Do not support image pulling progress when use cri-o as container runtime.

@kruise-bot kruise-bot requested review from Fei-Guo and furykerry March 18, 2022 06:14
@kruise-bot
Copy link

Welcome @diannaowa! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Mar 18, 2022
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #930 (e3568bc) into master (180279a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #930   +/-   ##
=======================================
  Coverage   49.42%   49.42%           
=======================================
  Files         119      119           
  Lines       11306    11306           
=======================================
  Hits         5588     5588           
  Misses       4857     4857           
  Partials      861      861           
Flag Coverage Δ
unittests 49.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 180279a...e3568bc. Read the comment docs.

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Mostly LG, well done!

pkg/daemon/criruntime/imageruntime/crio.go Outdated Show resolved Hide resolved
pkg/daemon/criruntime/imageruntime/crio.go Outdated Show resolved Hide resolved
pkg/daemon/criruntime/imageruntime/crio.go Outdated Show resolved Hide resolved
Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for working on this.

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 02f8fe6 into openkruise:master Mar 18, 2022
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
* support cri-o imageruntime


* fix go lint

* fix remove handleRuntimeError for CRI client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Add support for CRI-O
4 participants