Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support common CRI runtime based on cri-o impl #936

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Support common CRI runtime based on cri-o impl #936

merged 1 commit into from
Mar 21, 2022

Conversation

FillZpp
Copy link
Member

@FillZpp FillZpp commented Mar 21, 2022

Signed-off-by: FillZpp FillZpp.pub@gmail.com

Ⅰ. Describe what this PR does

Support common CRI runtime based on cri-o impl

@FillZpp
Support common CRI runtime based on cri-o impl
be5471c 
Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
@kruise-bot kruise-bot requested review from Fei-Guo and furykerry March 21, 2022 08:19
@kruise-bot kruise-bot added the size/M size/M: 30-99 label Mar 21, 2022
@FillZpp
Copy link
Member Author

FillZpp commented Mar 21, 2022

/cc @diannaowa

@kruise-bot
Copy link

@FillZpp: GitHub didn't allow me to request PR reviews from the following users: diannaowa.

Note that only openkruise members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @diannaowa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@diannaowa
Copy link
Contributor

/cc @FillZpp

@kruise-bot
Copy link

@diannaowa: GitHub didn't allow me to request PR reviews from the following users: FillZpp.

Note that only openkruise members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @FillZpp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

furykerry
furykerry reviewed Mar 21, 2022
View reviewed changes
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@FillZpp
Copy link
Member Author

FillZpp commented Mar 21, 2022

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: diannaowa, FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 234403c into openkruise:master Mar 21, 2022
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
@FillZpp
Support common CRI runtime based on cri-o impl (openkruise#936)
5753084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furykerry furykerry furykerry left review comments

@diannaowa diannaowa diannaowa approved these changes

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo

Assignees

@furykerry furykerry

Labels
approved lgtm size/M size/M: 30-99
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FillZpp @kruise-bot @diannaowa @furykerry