Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optmize the logic of listNamespacesForDistributor func #952

Merged

Conversation

hantmac
Copy link
Member

@hantmac hantmac commented Apr 18, 2022

Signed-off-by: hantmac hantmac@outlook.com

Ⅰ. Describe what this PR does

Optmize the logic of listNamespacesForDistributor func.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from FillZpp and furykerry April 18, 2022 03:45
@kruise-bot kruise-bot added the size/S size/S 10-29 label Apr 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #952 (19dfd52) into master (5b52b6e) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head 19dfd52 differs from pull request most recent head c560a0b. Consider uploading reports for the commit c560a0b to get more accurate results

@@            Coverage Diff             @@
##           master     #952      +/-   ##
==========================================
- Coverage   49.99%   49.90%   -0.10%     
==========================================
  Files         119      119              
  Lines       11535    11536       +1     
==========================================
- Hits         5767     5757      -10     
- Misses       4896     4903       +7     
- Partials      872      876       +4     
Flag Coverage Δ
unittests 49.90% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/resourcedistribution/utils.go 75.52% <100.00%> (+0.17%) ⬆️
pkg/controller/cloneset/cloneset_status.go 83.78% <0.00%> (-5.41%) ⬇️
pkg/controller/cloneset/cloneset_controller.go 52.17% <0.00%> (-4.35%) ⬇️
pkg/controller/daemonset/daemonset_update.go 55.75% <0.00%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b52b6e...c560a0b. Read the comment docs.

Signed-off-by: hantmac <hantmac@outlook.com>

exclude redundant list

Signed-off-by: hantmac <hantmac@outlook.com>
@hantmac hantmac force-pushed the opt/listNamespacesForDistributor branch from 19dfd52 to c560a0b Compare April 18, 2022 09:01
@veophi
Copy link
Member

veophi commented Apr 19, 2022

/lgtm

@FillZpp
Copy link
Member

FillZpp commented May 26, 2022

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 2dd93b6 into openkruise:master May 26, 2022
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Sep 14, 2022
Signed-off-by: hantmac <hantmac@outlook.com>

exclude redundant list

Signed-off-by: hantmac <hantmac@outlook.com>
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants