Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CloneSet status ExpectedUpdatedReplicas json name #963

Merged
merged 1 commit into from
Apr 24, 2022

Conversation

veophi
Copy link
Member

@veophi veophi commented Apr 24, 2022

Signed-off-by: veophi vec.g.sun@gmail.com

Ⅰ. Describe what this PR does

Fix CloneSet status ExpectedUpdatedReplicas json name

Signed-off-by: veophi <vec.g.sun@gmail.com>
@kruise-bot kruise-bot requested review from Fei-Guo and FillZpp April 24, 2022 05:37
@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Apr 24, 2022
@veophi veophi requested review from furykerry and removed request for Fei-Guo April 24, 2022 05:38
@furykerry
Copy link
Member

/lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #963 (12b211a) into master (8330213) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #963   +/-   ##
=======================================
  Coverage   50.00%   50.00%           
=======================================
  Files         119      119           
  Lines       11558    11558           
=======================================
  Hits         5779     5779           
  Misses       4901     4901           
  Partials      878      878           
Flag Coverage Δ
unittests 50.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8330213...12b211a. Read the comment docs.

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 5a71451 into openkruise:master Apr 24, 2022
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Sep 14, 2022
Signed-off-by: veophi <vec.g.sun@gmail.com>
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants