Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic cased by statefulset pvc auto deletion #999

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

veophi
Copy link
Member

@veophi veophi commented Jun 17, 2022

Signed-off-by: mingzhou.swx mingzhou.swx@alibaba-inc.com

Ⅰ. Describe what this PR does

Fix panic cased by statefulset pvc auto deletion

Ⅱ. Does this pull request fix one issue?

#997

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
@kruise-bot kruise-bot requested review from Fei-Guo and FillZpp June 17, 2022 09:56
@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Jun 17, 2022
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #999 (f1daf13) into master (54043e5) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
+ Coverage   49.07%   49.12%   +0.05%     
==========================================
  Files         125      125              
  Lines       12060    12060              
==========================================
+ Hits         5918     5925       +7     
+ Misses       5237     5232       -5     
+ Partials      905      903       -2     
Flag Coverage Δ
unittests 49.12% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/statefulset/stateful_set_utils.go 82.24% <100.00%> (ø)
pkg/controller/uniteddeployment/revision.go 67.93% <0.00%> (+1.52%) ⬆️
pkg/controller/cloneset/cloneset_controller.go 54.15% <0.00%> (+1.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54043e5...f1daf13. Read the comment docs.

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit ddd87f0 into openkruise:master Jun 17, 2022
FillZpp pushed a commit that referenced this pull request Jun 17, 2022
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>

Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Sep 14, 2022
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>

Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants