Icon edit code in sandbox #1129

AlitaBernachot · 2023-12-06T10:28:34Z

Updated example pages

Add an icon to open and edit the example in code sandbox
Removed ION token (provoking an error overlay layer in code sandbox)
examples now in html5
removed jquery (except for popup overlay)
vite is used in codesandbox (instead of parcel)

AlitaBernachot · 2024-09-11T08:29:40Z

gberaudo · 2024-09-13T08:40:06Z

examples/_code-sandbox.js

-            'cesium': '1.108',
-            'ol': '8.1.0'
+            'proj4': '2.11.0',
+            'cesium': '^1.90.0',


Do you mean 1.121.1 ?

examples/3dtiles.js

examples/_code-sandbox.js

gberaudo · 2024-10-04T08:09:36Z

examples/_code-sandbox.js

+  <script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/js/bootstrap.min.js"></script>
+</html>`;
+  const parameters = {
+    template: 'parcel',


template: 'parcel', is mandatory, to improve: see what the parcel template does and try to do the same in the codesanbox init to get rid of this line.

gberaudo · 2024-10-04T08:23:07Z

examples/fillstyle.js

-image.src = 'data/icon.png';
-
+image.src = 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAwCAYAAABwrHhvAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAACYZJREFUeNqkWGlsVNcV/u5bZvfYDGZxDHFillDcpKFQpaSCplWrNAhoQtQIK4ASqbSJ0iqFVGSVmh+hSWkaCVrSKhSCIjUtSyFuQxMQgVCEgMYsBtxS7LJjY3s84xnP8uatPfe9mbEHz3jjSsfz/O5yvrOf+5hlWciNsQfrXTCsHzNLqBcD7imiW5KBvvkRDxPQNc0yu9NthqLuYW5xfWTRX9v7L2E5AGMP1N/FwPZ4p02cKScqoMcT0HtjsFQFMMyRMxcEQBQhuryAJEJPxKG1dUUND3uiZ9nH+wsAkOQeZomnfHfXzkBnGpmLV6Df7IHeFoelWbYkIwdAh4sChAoXhJAPYsgPweNDprUtZVVIs3tWfnqeL5PsxYb1jHf6+BloT0NpbkX62FXoZ8OwdNM5iDGM1BRWvz/SneVwP1ANNsGCWBHwqVe71tHE4ixO0hQT6uVkBdRr7VAab0A73Un7LEIsQXDLYDa5RkSCh4g/u2QYbQmo/2qHmVAhlLvJMfBI8FcPVeQ1wLzu+7jNjUgC2plOMJlwEVNOjK9gwugdkWvRMGB0JWFGMhADBMznkvSYMpVmGx0ALtljxtMwu1K2vZmXGPvdEFwi6YiVPNtFQaLq2hCRQHbQRJgigxlTIVkiCUjnxgxP3gTcTpahw1QMW3rBLTnMJcEBUISCgTLsf+MDfPPeB0quyZNE8ZUVholZoUwL/QBwDMzRNFe/LA3KXKSw2vr8OsyqnYkPX3gHdTXTBwfAnZgigtGZFjFxnBqFAASeDzgoexMGHDJ72r3557efegnf/cqD9r6gL4AdazagsiJkz/HfO8ZOKNwvsrwpSUz+ZyCA7CxpgRDSBo6SCQ69vORH+OTVTZgz9ctwu1xo6bhSsO16903KNSJ8Hg92/nwDdq35HQI+f36/TbbUrFi6uGXY6/rQPz73Ybyy5Bl4XW7seGE9Jo2rwsXO6/bSj774DNFkHPF0Ah29Eby78nXMrq1D3eSp2PzsWttUhabAUAD6q12wVbl26ar8bGXZGPyyfhVlWCd//WTrWhxoPm4D/sGDj+DRr30nv3bBrPl4ct5iJyXnzDAkANsEzE6h3Azt8TCOXDhpS7jj+F57ya7G/TCZk5uXzVuIu8bdYT/v/GIfkpkUzl67gBOXmu13DacOOubk59nOh2GYYIAHA0dbm/DDLb8gBmnHPNmT3lq6GrPvrnMkyzrZ+n1/wtufbB14lggUQyANsL9wSyTQpkmhiXhq/mOkTQHzZ8yBomUKtuXmZUpMBfM55ma/cBwMgOP5Qj4SuN14tqurnoL1T75or1nxjUX59dw0QW+g5Lyb6gBT6BxL4KmumL6LRUEWKYG4v+ZL+P6sb5XMsvPWPY1jF8+UnH954cpbnJAN7YSO6h31nb5xAQ1Nn+Ni+DqWbXmV+pLCxuDwi1vx9dr7Ct5tPvIRNn6+zX5+89MtBdmQDVsDYl8C0ahGtHZew55zh5FU033qV5LY9++j+G/H5YLtxy6dwT9bT9rPmqlno4rlTVrSB0ynMehTFW2sHT8JD02fY/vBwdWb4OftVXa8uXcL/nB4J8b4gmh5vYFSvSPLawtW5jW1fO5CbDy4zTk8lwdYKQ3k7MOcfs6i/8OpGK5E2xH0+HH/pHvyTPjgcxxkVOkt0ExNqAq1ldX2MzdhPqtm/epWAI4GLFMVBMnFeBVk2V6KfuOUWD48sZcYiwNUF0335mP/bFsr/G5vwXx3sgfHrpzjRTZXgpxST0kp2wgbeQDUKrXLYnmNWu5zdGJYsJMdLXz/aAPeP9ZQ1Mtzwix672dFm0LOiPG6r1MQCia1YwHIooy0onON3MwDsHqV81q5WVPmLwOrGYdUWw/MDOUCUyiqtuF2pbakmkmdtQHXeC/GhCqRNjIwuc0EdqVPA7reZArmwwIljon3TEHUuorotS67ObHE0QPg9wmLtOmvDKLqqzOhkSl71BiMeOZc4t1Gs08DsnDQZMqahKCC6QzVddMweVotktFeaJnMqPtRUZLgHUNqryxHiumIZnpg9CbJJPpnhU4oi4cMJZmQPP5AT3cUvYle2/NDE8oRoEZDGEVXzNVP8iOhp9Ee64DKyOckC1pXnAv8jwIAke9tT4e2PbZLDgVXwM2gZ3R090TQHe0evQ9ki5GdiFzExi3aEWFcj11mHunIwGLkZlt0ll4heN0wUuSlCnmualCE6qNjTnEvEHOTumEeejwQjV6Fzla3pv7YZA5IRJFHdx3Sw/FTCHi5SRzi6Lkn81DiF9SRkGnaFdCubdSWWySqfjWSZl5pY8laYIrmWpNl+M2F1Oa00YNdTAaTnuVacbpj8GgyFRV6Z2Jz8rcnwiUBML+8S4vEGlmQ7m98o8u5H7ASzURp5k7uty8jPJRlKmoXw73kB28MWg0jC3ZYlmytNsgBBD+/ZArONSpfSNjwnU/OXsFIk0YiRd6f+HVy48mOIctx9ImGw1pX7M9U+uiGKztS5LQwHOntq5jgaI8E4G6unu9oYT5pXYnPCEVGuWuVno6FUeaYgg3HFP1Vn5Wck3otbJppbWVyw4nMsAFEl+zu1BX1OVOky6pfsg/KmYIVMwVj+TJuq56DJunNjALtUvc7yfdOHxrkQ0rx0bPi4+1aOPIBOSaYT3YOtUEIRf3B1g4HSgnHTjqU9TLNHWfhkV8b4kvOIGOM5zk1Fm0WuCk8knO4nDNFXwObs7uT8Yg8DGpLZ4pCr57CLjNqANHHdycohJboeiImBHMg+vyBZW9Sfcy59BRynTFLa48/zcZ6m4fxLWsIxw55L+ipzHKTaZZtDreYTS7ZDxhcIzxSPPTeQyGnKFD/0/Ebody9XZxUhtsHwHP5ON/fM+GeV3hY2SC8pAkeojniPkIATEtHpqntb/DLLwnVAQhV/tsHYF9YiaFY5X8r09H1e8tLgMooSQVkCAE3kQugd5ZoQjl947glsnqxKmBw6fm62weQy2zEiE3w/1S7Gd5mcg0E6f+gDBAQS7aZN1u6sUiY6E+JdxLzCo8TMUMMqXhO6Qux0IGliHz7L7wtlnmaEe8MPut/fo5Xnly5WOCxnlKQabzRop7pWKIeuMr7c94ea7RP739W/2/SRb8VF2Oe+xpH5MkCGEc0lxqKas/ymYvJ0Waal2M3M4eu7za7Uv+juSaiFg6ASCUQaQJf0CUNSwMlWkxOdBtBm6Xo7vSmM9uyJuTveazzQhPpt3ZY33ZZMVSseL6XsiRmGbMiAPllQ8+SdWuPWGz8X4ABALRql1gTFhStAAAAAElFTkSuQmCC';
+// voir si on peut pas corriger ça


We could declare data/icon.png to be a resource.

gberaudo · 2024-10-04T08:24:35Z

examples/groundvectors.js

+// faire à la demande
+// définir un objet
+// ex Ground vector titlre + urls list
+// introduire
+
+
+// voir
+//https://github.com/geoblocks/mapfishprint/tree/main/demo


What is the status of these comments?

gberaudo · 2024-10-04T08:26:30Z

examples/icon-position.js

+//##REMOVE## Keep this tag, split code here for code sandbox
+
+import {initCodeSandbox} from './_code-sandbox.js';
+initCodeSandbox('rawjs/icon-position.js');


Could we pass data/image-static.png and data/icon.png here to avoid base64-ing them?

gberaudo · 2024-10-04T08:27:11Z

examples/image-static.js

+//##REMOVE## Keep this tag, split code here for code sandbox
+
+import {initCodeSandbox} from './_code-sandbox.js';
+initCodeSandbox('rawjs/image-static.js');


Can we pass data/image-static.png as resource?

gberaudo · 2024-10-04T08:27:47Z

examples/imageWMS.js

@@ -43,8 +42,12 @@ const ol3d = new OLCesium({
    return Cesium.JulianDate.now();
  }
 });
-const scene = ol3d.getCesiumScene();
-Cesium.createWorldTerrainAsync().then(tp => scene.terrainProvider = tp);


Why do we remove the terrain?

gberaudo

Thanks for the hard work @AlitaBernachot , @vuilleumierc !

AlitaBernachot marked this pull request as draft December 6, 2023 10:28

AlitaBernachot mentioned this pull request Jan 9, 2024

Open examples in CodeSandbox #1041

Closed

AlitaBernachot force-pushed the icon-edit-code-in-sandbox-vite branch from ef6a477 to b76a0c8 Compare July 4, 2024 12:48

AlitaBernachot force-pushed the icon-edit-code-in-sandbox-vite branch 2 times, most recently from be7ead8 to 5925d48 Compare September 8, 2024 17:10

AlitaBernachot marked this pull request as ready for review September 8, 2024 17:46

AlitaBernachot force-pushed the icon-edit-code-in-sandbox-vite branch from 27be623 to be57411 Compare September 11, 2024 08:16

gberaudo reviewed Sep 13, 2024

View reviewed changes

examples/_code-sandbox.js Outdated

'cesium': '1.108',

'ol': '8.1.0'

'proj4': '2.11.0',

'cesium': '^1.90.0',

Copy link

Member

gberaudo Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean 1.121.1 ?

AlitaBernachot and others added 14 commits October 4, 2024 09:43

add button 'open in codesandbox'

5d42236

improve reusability of initCodeSandboxButton() and update all examples

60477eb

fix: update dep version and build with vite

935dcfb

feat(code-sandbox): enable tracking example in cs

7a8561f

feat(code-sandbox): enable selection example in cs

395ba27

feat(code-sandbox): replace .ts by .js

a588286

feat(code-sandbox): enable print example in cs

41ba736

feat(code-sandbox): enable buildings example in cs

b1c5648

fix: force dep version olcs and cesium for examples

90a63ca

fix(code-sandbox): make mvt example work again

6594928

feat(code-sandbox): enable overlay example in cs

21f1b7a

feat(code-sandbox): enable rotate example in cs

e642877

feat(code-sandbox): enable synth vector example in cs

c645e8e

feat(code-sandbox): enable wmts example in cs

0af1d93

gberaudo reviewed Oct 4, 2024

View reviewed changes

AlitaBernachot force-pushed the icon-edit-code-in-sandbox-vite branch from be57411 to b041e02 Compare October 4, 2024 08:46

AlitaBernachot added 5 commits October 4, 2024 16:30

temp rebase

faa33b1

fix: open in code sandbox

5e982dc

fix: add cmd for codesandbox in package.json

c9af8c5

fix: overlay example css

50f874f

fix: add cors anonymous for tracking

0a9ab74

AlitaBernachot and others added 15 commits October 4, 2024 16:30

fix: rastersync and sidebyside

74f8ee6

fix: vectors

2527f1d

fix: remove ion token and fix some examples

0c72568

fix: lint

f762d4e

chore : remove unused file

42a832d

feat: improve resourcesfiles loading

b5fa3c3

feat: update dep latest ol, proj4 and cesium

62f3872

fix: build examples

33f4fab

fix: do not use latest keyword for version in codesandbox

71333c1

fix: use the right js file

136c839

refactor: remove useless replace .ts to .js

4fcaf97

refactor: lz in one script

ac9eb53

Use global color

531b81d

Use Cesium 1.122

9559273

Cleanup

7a796e3

gberaudo force-pushed the icon-edit-code-in-sandbox-vite branch from d2aa8c2 to 7a796e3 Compare October 4, 2024 14:41

Update changelog

f44a4b2

gberaudo approved these changes Oct 4, 2024

View reviewed changes

gberaudo merged commit 398ed48 into openlayers:master Oct 4, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Icon edit code in sandbox #1129

Icon edit code in sandbox #1129

AlitaBernachot commented Dec 6, 2023 •

edited

Loading

AlitaBernachot commented Sep 11, 2024

gberaudo Sep 13, 2024

gberaudo Oct 4, 2024

AlitaBernachot Oct 4, 2024 •

edited

Loading

gberaudo Oct 4, 2024

gberaudo Oct 4, 2024

gberaudo Oct 4, 2024

gberaudo Oct 4, 2024

gberaudo Oct 4, 2024

gberaudo left a comment

Icon edit code in sandbox #1129

Icon edit code in sandbox #1129

Conversation

AlitaBernachot commented Dec 6, 2023 • edited Loading

Updated example pages

AlitaBernachot commented Sep 11, 2024

gberaudo Sep 13, 2024

Choose a reason for hiding this comment

gberaudo Oct 4, 2024

Choose a reason for hiding this comment

AlitaBernachot Oct 4, 2024 • edited Loading

Choose a reason for hiding this comment

gberaudo Oct 4, 2024

Choose a reason for hiding this comment

gberaudo Oct 4, 2024

Choose a reason for hiding this comment

gberaudo Oct 4, 2024

Choose a reason for hiding this comment

gberaudo Oct 4, 2024

Choose a reason for hiding this comment

gberaudo Oct 4, 2024

Choose a reason for hiding this comment

gberaudo left a comment

Choose a reason for hiding this comment

AlitaBernachot commented Dec 6, 2023 •

edited

Loading

AlitaBernachot Oct 4, 2024 •

edited

Loading