Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlighting alternating rows is inconsistent #27

Open
chaserx opened this issue Oct 14, 2015 · 3 comments
Open

highlighting alternating rows is inconsistent #27

chaserx opened this issue Oct 14, 2015 · 3 comments

Comments

@chaserx
Copy link
Member

chaserx commented Oct 14, 2015

I think the intent of the updated styling was to highlight alternate rows, but it seems (see screengrab) that it's not being applied consistently or that the order loading results is not as expected when this styling is applied.

screen shot 2015-10-14 at 1 16 02 pm

@jbonewits
Copy link

So this works as expected if there are no filters selected. Perhaps something about the order of when the highlighting is being applied relative to the filters is causing this behavior.
screen shot 2015-10-20 at 7 11 25 pm

@ashleybot
Copy link

So, the alternating backgrounds are achieved with CSS nth-child selectors. The styling appears to not update it's alternating appearance because elements are hidden (display:none) rather than removed. So, the CSS rules maintain.

So, one solution would be to purposely create .odd or .even CSS classes, assign them appropriately whenever the list is created/filtered.

@chaserx chaserx added the bug label Dec 3, 2015
@eeeschwartz
Copy link
Member

Currently, the list items that are visibly filtered out with style="display:none".

Let's instead toggle a class for hidden/visible. Then we could only target the visible items with the nth-child selector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants