-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
broken in IE #44
Comments
I don't have access to a windows machine, but we could probably look into a shortterm browserstack subscription |
I'm inclined to support IE9+ and watch the analytics to see how many IE8 and Windows Phone hits we get. Any thoughts? |
That seems fine to support IE9+ if we can have an overlay directing users to another browser. |
We could use something like http://outdatedbrowser.com/en but this too relies on JS and I think if there other JS errors as the Tabletop require error above that this may not be reliable. |
Browserstack has offered us a subscription in return for public acknowledgement on project |
wonder if we have to add to the shims: https://github.com/openlexington/finda/blob/gh-pages/src/script.js#L18-L34 |
if you add Tabletop into the Webpage error details
User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C)
Timestamp: Sun, 27 Dec 2015 16:10:03 UTC
Message: Script error
Line: 0
Char: 0
Code: 0
URI: https://spreadsheets.google.com/feeds/worksheets/1ubx07oylGxk5FDIjMnQo4cMNBd3a8QYiPm27rWuyByI/public/basic?alt=json&callback=Tabletop.callbacks.tt14512325595743253 |
So... JSON validators hate the |
I took a spin in IE11 and the live app is working well. Aside from the JSON validation, do you know of any other IE issues that should remain part of the soft launch? |
no, i don't know of other issues. |
it would be nice to have some indication that you must use a modern browser |
reported IE8 JS loading error. breaks the entire page. similar breakage in windows phone browser
“Tabletop is undefined”
The text was updated successfully, but these errors were encountered: