Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class to enum #958

Merged
merged 4 commits into from
Oct 5, 2020
Merged

Class to enum #958

merged 4 commits into from
Oct 5, 2020

Conversation

fsabr
Copy link
Contributor

@fsabr fsabr commented Oct 2, 2020

Reference Issue

To Resolve #951

What does this PR implement/fix? Explain your changes.

This PR converts the TaskTypeEnum class to an enum.Enum object

Copy link
Collaborator

@PGijsbers PGijsbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton! I think it's nearly ready for a merge, but I'd like to suggest two changes (see the comments):

  • the tasktypes is not defined in the example, which leads to an error
  • could you also please update the parameter names from task_type_id to task_type to better signal we moved away from using integers in the code?

examples/30_extended/tasks_tutorial.py Outdated Show resolved Hide resolved
examples/30_extended/tasks_tutorial.py Outdated Show resolved Hide resolved
openml/tasks/functions.py Outdated Show resolved Hide resolved
openml/tasks/functions.py Outdated Show resolved Hide resolved
openml/tasks/task.py Show resolved Hide resolved
@fsabr
Copy link
Contributor Author

fsabr commented Oct 3, 2020

I made the changes you said. Not sure about what I should do with the OpenMLTask class and its children.

@PGijsbers PGijsbers merged commit 0def226 into openml:develop Oct 5, 2020
@PGijsbers
Copy link
Collaborator

Thanks for your contribution! 🎉
If you're interested, there will a virtual OpenML workshop will be held October 26-30. It is a week long event where we get together to talk about and work on all things OpenML (this includes openml-python development). Visit OpenML to find out more!

@fsabr fsabr deleted the class-to-enum branch September 13, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert TaskType Class to a TaskType Enum
2 participants