Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage directory option is being overridden on load #170

Open
asbates opened this issue Dec 16, 2022 · 1 comment
Open

Storage directory option is being overridden on load #170

asbates opened this issue Dec 16, 2022 · 1 comment

Comments

@asbates
Copy link
Contributor

asbates commented Dec 16, 2022

The option staged.dependencies._storage_dir is being overridden if set by user (i.e. in .Rprofile). When the package is loaded, .onLoad calls setup_storage_dir(path.expand("~/.staged.dependencies")). Then setup_storage_dir takes the given path and sets the option.

On Windows ~/.staged.dependencies can be a OneDrive directory which can cause problems (#169). Regardless, we should not be overriding a user-defined option. We should probably clean up after ourselves as well, resetting any options that we set in the package (i.e. .onUnload())

@asbates
Copy link
Contributor Author

asbates commented Dec 16, 2022

Note: I'm not part of this org so I can't change assignee, label, etc. I am working on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant