Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples and test-files use visR:: notation, can probably be skipped. #300

Closed
timtreis opened this issue Jan 10, 2022 · 4 comments
Closed
Assignees
Labels
bug Something isn't working issue Used for project filtering
Milestone

Comments

@timtreis
Copy link
Collaborator

timtreis commented Jan 10, 2022

@SHAESEN2 do you have the technical suggestion of Daniel here?

@timtreis timtreis added bug Something isn't working issue Used for project filtering labels Jan 10, 2022
@SHAESEN2
Copy link
Collaborator

Daniel proposed to remove the visR:: (prefix) in all examples and test files because it will clash with users that use 'load all' in their workflow. I remember that R will then look for the properly installed visR instead of the rebuild package that you are developping.

@SHAESEN2
Copy link
Collaborator

Hey @timtreis I think I understand the issue. It is to support lazy/quick development so you dont have to rebuild the package every time. I think I prefer to keep prefix so we have maximal traceability. What do you think?

@SHAESEN2 SHAESEN2 added this to the v0.3.0 milestone Feb 26, 2022
@timtreis
Copy link
Collaborator Author

timtreis commented Mar 3, 2022

I came to the advanced side of R from doing transcriptomics in bioconductor where every second package reimplements all dplyr verbs, so I'm definitely pro-prefix :D

@bailliem
Copy link
Collaborator

bailliem commented Mar 3, 2022

I agree. For now I would prefer to have the prefix, but also happy to revisit it later when the package matures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working issue Used for project filtering
Projects
None yet
Development

No branches or pull requests

3 participants