Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README GH Action runs on PRs, main branch would be enough #340

Closed
timtreis opened this issue Mar 10, 2022 · 0 comments · Fixed by #342
Closed

README GH Action runs on PRs, main branch would be enough #340

timtreis opened this issue Mar 10, 2022 · 0 comments · Fixed by #342
Assignees
@timtreis @ddsjoberg
Labels
discussion Discussion around design choices and architecture

Comments

@timtreis
Copy link
Collaborator

Currently the GH Action that regenerates our README is run on all PRs and then commits them to the PR. Do we benefit from not just running it on our target branch (be it develop or main).
@timtreis timtreis added the issue Used for project filtering label Mar 10, 2022
@timtreis timtreis added discussion Discussion around design choices and architecture and removed issue Used for project filtering labels Mar 10, 2022
@ddsjoberg ddsjoberg mentioned this issue Mar 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timtreis timtreis

@ddsjoberg ddsjoberg

Labels
discussion Discussion around design choices and architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build README.Rmd on main branch instead of all PRs openpharma/visR
2 participants
@timtreis @ddsjoberg