Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README Contents Discussion #344

Closed
ddsjoberg opened this issue Mar 14, 2022 · 4 comments · Fixed by #369
Closed

README Contents Discussion #344

ddsjoberg opened this issue Mar 14, 2022 · 4 comments · Fixed by #369
Assignees
Milestone

Comments

@ddsjoberg
Copy link
Collaborator

Hello! I wanted to put out some ideas for some updates to the homepage/README.

The README is a place where someone new comes to learn about the package in a concise way. With that in mind, I think a few changes could be made.

  • Add an example of tableone()
  • Add an example of the attrition figure.
  • The figure showing the number of contributors is interesting. But it takes up a lot of space and doesn't a new visitor to the site learn about the package's functionality. An alternative that still exhibits the large contributor base, but also takes up less real-estate on the main page would be the output from usethis::use_tidy_thanks(), which lists the username of each contributor and links to their GH page.
  • Similarly, showing the number of commits I feel isn't the best use of space on the homepage of the pkg. Also, perhaps in one year's time, many of the existing functions and have been polished and there is far less development going on...the commits figure will look sad 😢
  • There is a badge showing the amazing code coverage. The badge links to a site where you can see the precise coverage of every function. As it's readily available, I don't think the README needs a table showing each file and its corresponding coverage.

I am happy to prepare a pull request that can be reviewed if there is interest.

@SHAESEN2 SHAESEN2 added this to the v0.3.0 milestone Mar 28, 2022
@SHAESEN2
Copy link
Collaborator

look at gtsummary readme for an example to print gttable as image

@ardeeshany
Copy link
Collaborator

Hi @ddsjoberg Did you mean pkgdown's index page or the README, or maybe both? If it's pkgdown, I couldn't find it in this repo. Could you please direct me to the pkgdown files?

@ddsjoberg
Copy link
Collaborator Author

ddsjoberg commented May 7, 2022

The README contents become the home page when the site is built with pkgdown. Is that what you're asking @ardeeshany ?

@ardeeshany
Copy link
Collaborator

@ddsjoberg Sorry I was reviewing the develop branch's README, which differed from the main branch's, therefore I assumed the pkgdown could have a separate index.md. Now, it is fine. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants