Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pare down the number of exported functions #381

Closed
ddsjoberg opened this issue May 22, 2022 · 0 comments · Fixed by #394
Closed

Pare down the number of exported functions #381

ddsjoberg opened this issue May 22, 2022 · 0 comments · Fixed by #394
Assignees
Labels
bug Something isn't working issue Used for project filtering
Milestone

Comments

@ddsjoberg
Copy link
Collaborator

ddsjoberg commented May 22, 2022

Only export functions intended for users (i.e. no helpers, etc).

Potential functions that are more internal than for use by a typical user

  • legendopts()
  • align_plots()
  • get_tableone()
  • get_summary()
  • the_lhs()
  • get_risktable() - I think it's fine to export this one eventually, but in its current state the output is in a format for internal use: not for use by users, e.g. returns a data frame with columns like y_value, which makes sense for how it's used internally in add_risktable(). But not useful for users.
  • All the summarize_*() functions
@ddsjoberg ddsjoberg added bug Something isn't working issue Used for project filtering labels May 22, 2022
@ddsjoberg ddsjoberg added this to the v0.3.0 milestone May 22, 2022
@bailliem bailliem self-assigned this May 23, 2022
@bailliem bailliem linked a pull request May 31, 2022 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working issue Used for project filtering
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants