Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUDA 12 changes, replace texture references with texture objects #137

Closed
wants to merge 2 commits into from

Conversation

pieris98
Copy link

Replaced deprecated texture references (which don't work in CUDA 12) with textureObjects. ppl.cv cuda-build builds successfully on my machine (RTX3090, sm86 compute capability, CUDA toolkit version 12.2), but I haven't run any tests to check for correctness of the updated kernels. Please review and merge at your will.

Remove unsupported compute capability GPUs for CUDA 12
@jimurk
Copy link
Collaborator

jimurk commented Jul 1, 2024

Thanks for your work. Since we want to maintain support to some old gpus, we hope to add new features while carefully removing old code. So, you can have code of both texture objects and texture references using the following macro definition and don't comment code in cuda.cmake.

#if CUDACC_VER_MAJOR == 12
// code using texture Objects
#else
// code using texture references
#endif

@jimurk jimurk closed this Jul 1, 2024
@pieris98
Copy link
Author

pieris98 commented Jul 1, 2024

Are you going to review the code changes and wrap them with these statements (I suppose you mean #ifdef??) or are you waiting for a new PR?

@Saeedmatt3r
Copy link

@pieris98 I faced this problem as well. I think you need to check the CUDA version during compilation to avoid breaking previous functionalities(for those who have different cuda versions). Although the PR might be great, they can't merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants