Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

olefile as a dependency at version >= 0.46 #198

Closed
jamiepb opened this issue Mar 12, 2021 · 2 comments · Fixed by #195
Closed

olefile as a dependency at version >= 0.46 #198

jamiepb opened this issue Mar 12, 2021 · 2 comments · Fixed by #195
Assignees
Labels
feature New functionality to be developed P2 Medium priority issues to be scheduled in a future release
Milestone

Comments

@jamiepb
Copy link

jamiepb commented Mar 12, 2021

Hello,

I ran into the following error when running fido 1.4.1 on a .doc file (identified as Microsoft Word 97-2003 by Windows 10):

Traceback (most recent call last):
File "/usr/local/bin/fido", line 11, in
sys.exit(main())
File "/usr/local/lib/python3.6/dist-packages/fido/fido.py", line 861, in main
fido.identify_file(file, extension=not args.noextension)
File "/usr/local/lib/python3.6/dist-packages/fido/fido.py", line 362, in identify_file
container_matches = self.match_container("OLE2", OlePackage, filename, container_file)
File "/usr/local/lib/python3.6/dist-packages/fido/fido.py", line 211, in match_container
puids = klass(file, self.extract_signatures(signature_file, signature_type=signature_type)).detect_formats()
File "/usr/local/lib/python3.6/dist-packages/fido/package.py", line 40, in detect_formats
with olefile.OleFileIO(self.ole) as ole:
AttributeError: enter

I was using ole 0.45.1 and once I upgraded it to 0.46, it was able to identify the file:

FIDO v1.4.1 (formats-v96.xml, container-signature-20200121.xml, format_extensions.xml)
OK,140,fmt/111,"OLE2 Compound Document Format","OLE2 Compound Document Format",22528,"Desktop/Easley_Backup_appraisal_bag/Easley_backup_20110930/August 11/Education Video Transcript.doc","None","signature"
FIDO: Processed 1 files in 209.69 msec, 5 files/sec

Would you consider testing having olefile 0.46 as a dependency for fido?

Thank you,

Jamie Patrick-Burns

@mistydemeo
Copy link
Contributor

Thanks for reporting this issue! The version has been updated in #195, but there hasn't been a new release that includes that change yet. This'll be fixed when the next version comes out.

@carlwilson carlwilson added feature New functionality to be developed P2 Medium priority issues to be scheduled in a future release labels Apr 20, 2021
@carlwilson carlwilson added this to the v1.6 milestone Apr 20, 2021
@carlwilson carlwilson linked a pull request Apr 20, 2021 that will close this issue
@carlwilson
Copy link
Member

#195 closes this issue in v1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality to be developed P2 Medium priority issues to be scheduled in a future release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants