Added ERA5 support for initialization

[syedhamidali]

Replaced ERA-interim successfully with ERA-5, and It is working fine.
While running flake8 tests manually, I changed some line spacing in other functions as well (not any code or logic), but the linting workflow on GitHub is somehow failing, you might wanna take a look.
The function is named as make_initialization_from_era5
Thanks!

[rcjackson]

Hamid, could you please install precommit in your environment:

https://pre-commit.com/

Then run the pre-commit hooks over all files and commit the changes that are made to this PR. The instructions for installing precommit and running the hooks are at the link above.

[syedhamidali]

Bobby,
Done! Check out commit 4

[rcjackson]

Very nice! Linting passes now! One other thing that needs to be done is that the unit test for era_interim also needs to be updated:
FAILED pydda/tests/test_ecmwf.py::test_era_initialization - AttributeError: module 'pydda.initialization' has no attribute 'make_initialization_from_era_interim'

The file pydda/tests/test_ecmwf.py contains this unit test. I would update it to match the same time period and location, but for ERA5.

I am fine with ERA-Interim support being removed as ERA5 has replaced ERA-Interim.

[syedhamidali]

Do you want me to work on tests as well, I could probably give it a try.

[rcjackson]

If you could work on the unit test, that would be greatly appreciated! From: Hamid Ali Syed ***@***.***> Date: Tuesday, September 5, 2023 at 10:24 AM To: openradar/PyDDA ***@***.***> Cc: Jackson, Robert ***@***.***>, Comment ***@***.***> Subject: Re: [openradar/PyDDA] Added ERA5 support for initialization (PR #99) Do you want me to work on tests as well, I could probably give it a try. — Reply to this email directly, view it on GitHub<#99 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFIQA5EQAXFT2YFEU4HGQXDXY47XVANCNFSM6AAAAAA4LDMZI4>. You are receiving this because you commented.Message ID: ***@***.***>

[syedhamidali]

I did make some changes in unit tests, but there is some issue with absolute tolerance parameter. Since, I added the era5 file for Grid, you may have to redifne these tolerances

[rcjackson]

All tests have passed! Thank you @syedhamidali for this great contribution!