Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ethics reviewing domain fields on deployment #2301

Closed
haroldrubio opened this issue Aug 1, 2024 · 1 comment · Fixed by #2359
Closed

Add ethics reviewing domain fields on deployment #2301

haroldrubio opened this issue Aug 1, 2024 · 1 comment · Fixed by #2359
Labels
arr Issues related to the ARR workflow august_cycle

Comments

@haroldrubio
Copy link
Member

These fields get populated after the ethics review stage is run but we can populated these field on deployment since this information is asked for in the request form

if self.venue.ethics_review_stage:
content['ethics_chairs_id'] = { 'value': self.venue.get_ethics_chairs_id() }
content['ethics_chairs_name'] = { 'value': self.venue.ethics_chairs_name }
content['ethics_reviewers_name'] = { 'value': self.venue.ethics_reviewers_name }
content['ethics_review_name'] = { 'value': self.venue.ethics_review_stage.name }
content['anon_ethics_reviewer_name'] = { 'value': self.venue.anon_ethics_reviewers_name() }
content['release_submissions_to_ethics_chairs'] = { 'value': self.venue.ethics_review_stage.release_to_chairs }

@melisabok
Copy link
Member

I think we would need to fix this ASAP because next time the ARR venue request is being used the ethics_chair_id value that you added to the domain will be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arr Issues related to the ARR workflow august_cycle
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants