traverse recipes to leaf nodes first before checking type in order to…

… handle composite recipes
openrewrite · Jun 30, 2021 · 2763494 · 2763494
1 parent a68c947
commit 2763494
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/main/java/org/openrewrite/maven/AbstractRewriteMojo.java b/src/main/java/org/openrewrite/maven/AbstractRewriteMojo.java
@@ -339,6 +339,10 @@ protected ResultsContainer listResults() throws MojoExecutionException {
     }
 
     private void discoverRecipeTypes(Recipe recipe, Set<Class<?>> recipeTypes) {
+        for (Recipe next : recipe.getRecipeList()) {
+            discoverRecipeTypes(next, recipeTypes);
+        }
+
         try {
             Method getVisitor = recipe.getClass().getDeclaredMethod("getVisitor");
             getVisitor.setAccessible(true);
@@ -354,9 +358,6 @@ private void discoverRecipeTypes(Recipe recipe, Set<Class<?>> recipeTypes) {
             } else if (visitor instanceof YamlVisitor) {
                 recipeTypes.add(YamlVisitor.class);
             }
-            for (Recipe next : recipe.getRecipeList()) {
-                discoverRecipeTypes(next, recipeTypes);
-            }
         } catch (NoSuchMethodException | InvocationTargetException | IllegalAccessException ignored) {
             // not every recipe will implement getVisitor() directly, e.g. CompositeRecipe.
         }