Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove public visibility of JUnit 5 tests #498

Merged
merged 4 commits into from
Feb 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

import static org.assertj.core.api.Assertions.assertThat;

public class AbstractRewriteMojoTest {
class AbstractRewriteMojoTest {

@ParameterizedTest
@ValueSource(strings = {"rewrite.yml", "https://httpstat.us/200"})
Expand All @@ -32,7 +32,7 @@ public void execute() {
}
};

if(!loc.startsWith("http")) {
if (!loc.startsWith("http")) {
Files.write(temp.resolve(loc), "rewrite".getBytes(StandardCharsets.UTF_8));
}

Expand Down
3 changes: 1 addition & 2 deletions src/test/java/org/openrewrite/maven/BasicIT.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,13 @@

import com.soebes.itf.jupiter.extension.*;
import com.soebes.itf.jupiter.maven.MavenExecutionResult;
import org.junit.jupiter.api.Disabled;

import static com.soebes.itf.extension.assertj.MavenITAssertions.assertThat;

@MavenJupiterExtension
@MavenOption(MavenCLIOptions.NO_TRANSFER_PROGRESS)
@SuppressWarnings("NewClassNamingConvention")
public class BasicIT {
class BasicIT {

@MavenTest
void groupid_artifactid_should_be_ok(MavenExecutionResult result) {
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/openrewrite/maven/ConfigureMojoIT.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
@SystemProperty(value = "dependencies", content = "org.openrewrite.recipe:rewrite-spring:4.14.1")
})
@SuppressWarnings("NewClassNamingConvention")
public class ConfigureMojoIT {
class ConfigureMojoIT {

@MavenTest
void single_project(MavenExecutionResult result) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
@MavenJupiterExtension
@MavenOption(MavenCLIOptions.NO_TRANSFER_PROGRESS)
@MavenGoal("${project.groupId}:${project.artifactId}:${project.version}:discover")
public class DiscoverNoActiveRecipeIT {
class DiscoverNoActiveRecipeIT {

@MavenTest
void single_project(MavenExecutionResult result) {
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/openrewrite/maven/InitMojoIT.java
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
@SystemProperty(value = "rootOnly", content = "false")
})
@SuppressWarnings("NewClassNamingConvention")
public class InitMojoIT {
class InitMojoIT {

@MavenTest
void single_project(MavenExecutionResult result) {
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/openrewrite/maven/RemoveMojoIT.java
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
@MavenOption(MavenCLIOptions.NO_TRANSFER_PROGRESS)
@MavenGoal("${project.groupId}:${project.artifactId}:${project.version}:remove")
@SuppressWarnings("NewClassNamingConvention")
public class RemoveMojoIT {
class RemoveMojoIT {

@MavenTest
void single_project(MavenExecutionResult result) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
@MavenOption(MavenCLIOptions.NO_TRANSFER_PROGRESS)
@MavenGoal("${project.groupId}:${project.artifactId}:${project.version}:cyclonedx")
@SuppressWarnings("NewClassNamingConvention")
public class RewriteCycloneDxIT {
class RewriteCycloneDxIT {

@MavenTest
@Disabled("module b consistently fails to resolve the locally-built artifact a due to aether resolution errors")
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/openrewrite/maven/RewriteDiscoverIT.java
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
@MavenOption(MavenCLIOptions.NO_TRANSFER_PROGRESS)
@MavenGoal("${project.groupId}:${project.artifactId}:${project.version}:discover")
@SuppressWarnings("NewClassNamingConvention")
public class RewriteDiscoverIT {
class RewriteDiscoverIT {

@Nested
@MavenGoal("${project.groupId}:${project.artifactId}:${project.version}:discover")
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/openrewrite/maven/RewriteDryRunIT.java
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
@MavenOption(MavenCLIOptions.NO_TRANSFER_PROGRESS)
@MavenOption(MavenCLIOptions.DEBUG)
@MavenGoal("${project.groupId}:${project.artifactId}:${project.version}:dryRun")
public class RewriteDryRunIT {
class RewriteDryRunIT {

@MavenTest
void fail_on_dry_run(MavenExecutionResult result) {
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/openrewrite/maven/RewriteRunIT.java
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
@DisabledOnOs(OS.WINDOWS)
@MavenGoal("${project.groupId}:${project.artifactId}:${project.version}:run")
@SuppressWarnings("NewClassNamingConvention")
public class RewriteRunIT {
class RewriteRunIT {

@MavenTest
void multi_module_project(MavenExecutionResult result) {
Expand Down