Jenkinsfile parsing/testing/manipulating - Does it work?

[crankydillo]

I need to modify some Jenkinsfile and started out with a test similar to this and impl code that uses your TreeVisitingPrinter:

rewriteRun(
                //language=groovy
                groovy(
                        """
                    @Library('hello')_
                    somePipeline {
                    }
                          """,
                        """
                    @Library('hello')_
                    somePipeline {
                      defaults = someDefaults()
                    }     
                          """,
                        spec -> spec.path("Jenkinsfile")
                )
        );

When I run this via JUnit, I get:

java.lang.AssertionError: Source file was parsed into an LST that contains non-whitespace characters in its whitespace. This is indicative of a bug in the parser. 
@Li~~(non-whitespace)~~>brary('hello')<~~_
somePipeline {
}

	at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:323)
	at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:131)
	at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:126)

I assume this is happening because it's using your GroovyParser, and that understandably doesn't handle this Jenkins DSL thing (I think there's a question somewhere about this).. However, when I use my recipe via the MavenPlugin, the tree printer does seem to walk the statements. So 2 questions.

1. Can I reasonably modify the Jenkinsfile even with these test problems? I'm about to try that out, but figured I'd ask anyway:). Maybe it will help some others. I know I've spoken with people who think OpenRewrite can easily modify Jenkinsfiles in the same way it can modify Maven pom files and Java source code.
2. Is there any non-hacky way to make the test work? Can I reasonably bypass the whitespace validation? I'm going down a pretty hacky override path of GroovyBuilder, where I'm overriding service...

[crankydillo]

Currently, I'm omitting Jenkinsfile DSL stuff like @Library("foo")_ (pretty sure this is Jenkinsfile DSL, not Groovy) and asserting on changes that can be successfully represented as Groovy. Then I do some adhoc testing on real Jenkinsfile. Seems to be working ok. Ideally, I could test the Jenkinsfile. Maybe I could try treating is a text or something, but somehow force the use of my visitor.

[shanman190]

So I would have expected a Jenkinsfile to parse without any issues. Based upon the output there, it seems the Groovy parser visitor got confused on something...

[timtebeek]

Hmm; we do have a similar if slightly different issue report already:

• Jenkinsfile changed by UpgradeToJava17 / RemoveTrailingWhitespace recipes #3824

Both need a closer look at the parser to see this resolved, and the tests are a helpful first step, thanks! Did you already explore a possible fix as well?