feat(scl-transformation): automatic IEDName subscriber auto-complete #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca-d
suggested changes
Feb 16, 2021
|
This could use a rebase on the current main branch. |
JakobVogelsang
force-pushed
the
add-gesecontrol-subscriber-info
branch
from
8e025a1
to
eda060a
Compare
* feat(editors/substation): add duplicate feature to bay and voltage level editors * test(snapshots): fix bay and voltage level editor snapshot * refactor(editors/foundation): remove unused imports * refactor(editors/fondation): simplify cloneElement function * feat(substation/foundation): add error message for unsuccessfull copy * docs(foundation): document createElement Co-authored-by: Christian Dinkel <chhildeb@gmail.com> Co-authored-by: Christian Dinkel <christian.dinkel@omicronenergy.com>
* feat(editors/network): initial tab * feat(editors/network): add initial network plug-in * refactor(communication/plugin): add snapshot test and correct naming * feat(editors/communication/subnetwork-editor): initial attemed without tests * fix(editors/communication/subnetwork): add missing editors * fix(integration-tests): fixed wrong input * test(editors/communication/subnetwork-editor): add integration and unit tests * refactor(foundation): change compareName to accept Element and String * feat(editors/communication/connectedap): initial push dispaying all ConnectedAP sorted by IED * feat(editors/communication/connectedap): allow add and delte capability * test(editors/communication/subnetwork): update snapshot * refactor(editors/communication/p-type): add pattern for important schema versions * refactor(editors/communication/connectedap): change to mulit select on adding new connectedap's * refactor(editors/communication/connectedap): refactor p-type and edit wizard * refactor(editors/communication/connectedap): name correction * feat(communication/editors/connectedap): edit Address field within ConnectedAP element * refactor(editors/communication/connectedap): remove unused properties * fix(editors/communication/p-types): fix ipV4 pattern requirements * test(editors/communication/connectedap): add integration tests * refactor(plugin/communication): smaller code improvements * refactor(editors/communication/connected-ap): code improvement * fix(editors/communication/sonnected-ap): remove wrong import statemant * refactor(editors/communication/connected-ap): make editAction more stable * test(editors/communication/connected-ap): add unit tests * refactor(editors/communication/subnetwork): use createElement function to add SubNetwork element * refactor(editors): fix wrong lower case interface name * refactor(editors/communication/subnetwork): change unique filter to inline function * refactor(editors/communication/connectedap): convert static methods to functions * refactor(style): delete superflous abbr styling * fix(editors/communication/subnetwork): remove import statement for removed function * chore(editors/communication/connectedap): make comment less obtrusive * fix(editors/communications/connectedap): check for equal address elements inverted * refactor(editors/communication/connectedap): clearify reference element in Create action * refactor(editors/communication): remove superfluous translations and add missing translations * docs(editors/communication/connectedap): stop shouting Co-authored-by: Christian Dinkel <christian.dinkel@omicronenergy.com>
* feat(editors/substation): add duplicate feature to bay and voltage level editors * test(snapshots): fix bay and voltage level editor snapshot * refactor(editors/foundation): remove unused imports * refactor(editors/fondation): simplify cloneElement function * feat(substation/foundation): add error message for unsuccessfull copy * docs(foundation): document createElement Co-authored-by: Christian Dinkel <chhildeb@gmail.com> Co-authored-by: Christian Dinkel <christian.dinkel@omicronenergy.com>
…slation information
JakobVogelsang
force-pushed
the
add-gesecontrol-subscriber-info
branch
from
eda060a
to
6bee9ea
Compare
ca-d
reviewed
Feb 20, 2021
test/integration/open-scd.test.ts
Outdated
| @@ -251,7 +251,7 @@ describe('open-scd', () => { | |||
| 'No IED element in the file' | |||
| ); | |||
| }); | |||
| it('throws doblicate ied name error', async () => { | |||
| it('throws dublicate ied name error', async () => { | |||
There was a problem hiding this comment.
this is actually spelt "duplicate" 😉
ca-d
approved these changes
Feb 20, 2021
|
Closes #82 . |
|
Sorry for the accidental premature closing of this request. |
JakobVogelsang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.