Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make use of lerna nx #1462

Merged
merged 7 commits into from
Mar 19, 2024
Merged

feat: make use of lerna nx #1462

merged 7 commits into from
Mar 19, 2024

Conversation

Stef3st
Copy link
Contributor

@Stef3st Stef3st commented Feb 26, 2024

closes #1420

@Stef3st
feat: make use of lerna nx
7bbf36b 
Signed-off-by: Steffen van den Driest <steffen.van.den.driest@alliander.com>
@Stef3st Stef3st linked an issue Feb 26, 2024 that may be closed by this pull request
Make use of Lerna / Nx for Monorepository #1420
Closed
3 tasks
@Stef3st Stef3st marked this pull request as ready for review February 26, 2024 14:30
@Stef3st
Copy link
Contributor Author

Stef3st commented Feb 26, 2024

The test, start and doc scripts were not being used by both projects in the previous workflows. Since we want to get rid of cd'ing I excluded the unneeded package in the lerna scripts at root level. Please check this out as well and let me know if this is an acceptable solution or if we should take another approach.

pascalwilbrink
pascalwilbrink previously requested changes Feb 26, 2024
View reviewed changes
Copy link
Member

@pascalwilbrink pascalwilbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing individual project.json files (Nx)
npm run build should be Nx, not lerna
npm test should not exclude core
npm start should not exclude core
npm run doc should not exclude core

Build should be depending on clean and build

@Stef3st Stef3st marked this pull request as draft February 27, 2024 20:34
@Stef3st
Merge branch 'main' into 1420-make-use-of-lerna-nx-for-monorepository
2a98b08 
Signed-off-by: Steffen van den Driest <steffen.van.den.driest@alliander.com>
@Stef3st
chore: added project.json and corrected scripts
a02a5e4 
Signed-off-by: Steffen van den Driest <steffen.van.den.driest@alliander.com>
@Stef3st
chore: removed not working test scripts
537dd1a 
Signed-off-by: Steffen van den Driest <steffen.van.den.driest@alliander.com>
@Stef3st Stef3st marked this pull request as ready for review March 15, 2024 06:30
@Stef3st Stef3st dismissed pascalwilbrink’s stale review March 15, 2024 11:34

These requested changes are already inplemented

pascalwilbrink
pascalwilbrink reviewed Mar 19, 2024
View reviewed changes
packages/plugins/project.json Outdated Show resolved Hide resolved
packages/open-scd/project.json Outdated Show resolved Hide resolved
@pascalwilbrink pascalwilbrink merged commit 94d68d7 into main Mar 19, 2024
5 checks passed
@pascalwilbrink pascalwilbrink deleted the 1420-make-use-of-lerna-nx-for-monorepository branch March 19, 2024 15:59
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwilbrink pascalwilbrink pascalwilbrink approved these changes

@juancho0202 juancho0202 Awaiting requested review from juancho0202

@trusz trusz Awaiting requested review from trusz

Assignees
No one assigned
Labels
None yet
Projects
PR Overview
Status: Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make use of Lerna / Nx for Monorepository
3 participants
@Stef3st @pascalwilbrink @juancho0202