Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): reload official plugins without reset #196

Merged
merged 1 commit into from
May 14, 2021
Merged

Conversation

JakobVogelsang
Copy link
Collaborator

Closes #176

@JakobVogelsang JakobVogelsang added this to the Sprint 2021-05-14 milestone May 12, 2021
@JakobVogelsang JakobVogelsang requested a review from ca-d May 12, 2021 22:21
Copy link
Contributor

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,50 @@
export const officialPlugins = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this file is js and not ts? For customisability without recompilation?

@ca-d ca-d merged commit dd9c8d5 into main May 14, 2021
@ca-d ca-d deleted the refactor-plugin branch May 14, 2021 14:21
pascalwilbrink pushed a commit that referenced this pull request Sep 11, 2023
Create CoMPAS Mixin with Session Expire Dialogs and other loading logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load new plugins without reset
2 participants