-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editors/templates/lnodetype-wizards): add basic lnodetype manipulation capabilities #213
feat(editors/templates/lnodetype-wizards): add basic lnodetype manipulation capabilities #213
Conversation
f50e0db
to
6180acc
Compare
79b87b4
to
3d10564
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/editors/templates/foundation.ts
Outdated
@@ -48,10 +49,26 @@ export function updateIDNamingAction(element: Element): WizardActor { | |||
}; | |||
} | |||
|
|||
function isActionUnique(actions: Create[], newAction: Create): boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this could be renamed to containsCreateAction(actions: Create[], action: Create): boolean
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a better name, I agree! Thanks
chore: init elastic monitoring
Closes #211