Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gsecontrol): edit GSEControl and its referenced elements #278

Merged
merged 38 commits into from
Aug 4, 2021
Merged

feat(gsecontrol): edit GSEControl and its referenced elements #278

merged 38 commits into from
Aug 4, 2021

Conversation

JakobVogelsang
Copy link
Collaborator

Closes #145

Jakob Vogelsang and others added 25 commits July 30, 2021 21:33
feat(abstractda): create valAction and renderWizard to be used by bot…
ed85150 
…h BDA and DA wizards
fix(abstractda): name pattern and maxLength
658602f
fix(abstractda): name attributes limits
e082929
test(abstractda): update snapshot
c90baaf
refactor(bda): move bDAWizard to wizard-library
d448979
feat(bda): createBDaAction create Val
a135336
refactor(datype-wizards): remove unused bda eizards and actions
a0bcf2b
feat(da) add Val,dchg,achg,dupd to da wizards
7958477
feat(da): add Val,dchg,qchg,dupd to createDaWizard
3c6c163
fix(da and bda): minor fixes
75df324
@JakobVogelsang
feat(wizard/gsecontrol): initial commit
67b34d2
feat(wizards/gse): add edit wizard
5ccc18e
feat(wizards/dataset): allow XML editor on edit wizard
9a65625
test(wizards/gsecontrol): add unit tests
99ce2ac
test(wizards/dataset): add unit tests
559ae88
fix(wizard/gsecontrol): type option GSSE
f6648ec
test(wizards/gse): add unit tests
0e3bb8f
test(wizard/address): add unit tests
ae06f41
test(wizards/address): improve unit tests
79e3db8
fix(templates): fix wrong translation term
a2c11b7
feat(wizards/gsecontrol): add translations
6ca5ae5
feat(wizards/gsecontrol): update translations
06a8f5a
feat(ied-editor/zeroline-pane): open selectGsecontrolWizard
b7a0dc7
fix(wizards/bda,da): fix translation term
2b58fd2
fix: several translation issues
e9d3e90
@JakobVogelsang JakobVogelsang added Kind: Enhancement New Request Priority: Important Tackle eventually labels Aug 2, 2021
@JakobVogelsang JakobVogelsang added this to the Sprint 2021-08-13 milestone Aug 2, 2021
@JakobVogelsang JakobVogelsang marked this pull request as ready for review August 3, 2021 08:56
ca-d
ca-d suggested changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the foundation.ts directory name.

src/wizards/foundation.ts/p-types.ts Outdated Show resolved Hide resolved
@JakobVogelsang JakobVogelsang merged commit b5b39c4 into main Aug 4, 2021
@JakobVogelsang JakobVogelsang deleted the add-basic-gsecontrol-manipulation-capability branch August 4, 2021 06:04
Stef3st pushed a commit that referenced this pull request Nov 2, 2023
@pascalwilbrink
Merge pull request #278 from com-pas/Move_UserInfo_To_Compas_Foundation
d7fe04c 
Move user info to compas foundation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ca-d ca-d ca-d requested changes

Assignees
No one assigned
Labels
Kind: Enhancement New Request Priority: Important Tackle eventually
Projects
None yet
Milestone
Sprint 2021-08-13
Development

Successfully merging this pull request may close these issues.

GOOSE control block manipulation capability
2 participants
@JakobVogelsang @ca-d