Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(open-scd): add save functionality #54

Merged
merged 5 commits into from
Dec 10, 2020
Merged

feat(open-scd): add save functionality #54

merged 5 commits into from
Dec 10, 2020

Conversation

ca-d
Copy link
Contributor

@ca-d ca-d commented Dec 9, 2020

Closes #4

@ca-d ca-d self-assigned this Dec 9, 2020
@ca-d ca-d added the Kind: Enhancement New Request label Dec 9, 2020
@ca-d ca-d added this to the 0.1.0 milestone Dec 9, 2020
@ca-d
Copy link
Contributor Author

ca-d commented Dec 9, 2020

This cannot be tested because downloads are built in browser functionality.

JakobVogelsang
JakobVogelsang reviewed Dec 9, 2020
View reviewed changes
Copy link
Collaborator

@JakobVogelsang JakobVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Save As... function would be nice to have. This was one of the most asked features in the java version.

@ca-d
Copy link
Contributor Author

ca-d commented Dec 10, 2020

I've added a "Save as" button.

@ca-d ca-d merged commit bb9a967 into master Dec 10, 2020
@ca-d ca-d deleted the add-save-button branch December 10, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobVogelsang JakobVogelsang JakobVogelsang left review comments

Assignees

@ca-d ca-d

Labels
Kind: Enhancement New Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "save SCD file" button
2 participants
@ca-d @JakobVogelsang