Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI][Discussion] frightening and unimportant messages displayed to the user #321

Closed
set-soft opened this issue Aug 12, 2022 · 3 comments
Closed

Comments

@set-soft
Copy link
Contributor

The following code:

print('Git version check failed: ' + str(e))
except Exception as e:
print('Git process cannot be launched: ' + str(e))

Displays some debug messages that I don't think are relevant to the end user. Why the code assumes the script is running from a repo clone?
I think these messages should be displayed only when debugging (BTW I don't think the verbosity can be controlled from the CLI).

My main current problem is that when I try to find the iBoM version I must filter these messages. They could also be printed to stderr, along with other messages created by KiCad, but most people will get confused anyways.

What do you think about this @qu1ck ?

@qu1ck
Copy link
Member

qu1ck commented Aug 13, 2022

Code doesn't assume it, it just tries to get more exact version info with the commit sha for debug purposes.
Print statements can be reworded to indicate this is just informational or removed altogether.

@set-soft
Copy link
Contributor Author

I think they should be removed, after all this isn't an error, just the code running normally as installed from the KiCad package manager. Do you want a PR removing them (I think commenting them is the best, so you can uncomment them for debug).

@qu1ck qu1ck closed this as completed in 31b20f8 Aug 16, 2022
@set-soft
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants